Skip to content

[Issue] Refactor moveFileFromTmp to not use a static method call #29598

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #27581: Refactor moveFileFromTmp to not use a static method call


Summary (*)

Magento 2.4-develop
Currently the class \Magento\Catalog\Model\ImageUploader has a static call to Uploader::getNewFileName

In this PR I plan to:

  • Create new class for the method getNewFileName,
  • Refactor the \Magento\Catalog\Model\ImageUploader class to use this new class,

Examples (*)

  1. Upload an image to a category with a unique name and check that name has not been changed,
  2. Upload an image to a category with a nonunique name and check that the name has been updated to be unique,

Proposed solution

I am not too sure on the naming of the new class but would be happy to update it if needed.
I am also not sure about if I need an optional injection of my new class to the ImageUploader class.

Metadata

Metadata

Assignees

Labels

Component: CatalogComponent: FileComponent: TestFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions