Support different store in CountryInformationAcquirer

[evs-xsarus]

Description (*)

The functions in \Magento\Directory\Api\CountryInformationAcquirerInterface get their data based on the current store. In custom exports to third parties, eg. and order export, one can inject this interface to get country information based on the shipping address. To get the correct information, the order's store should be used in the functions.

Currently, when eg, Spain isn't in the allowed countries for the default store, but the order's created in store that does allow Spain, the function getCountryInfo throws an exception "The country isn't available.".

To achieve this, add an optional argument to the functions, so a different store view can be provided.

[m2-assistant]

Hi @evs-xsarus. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[evs-xsarus]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @evs-xsarus. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @evs-xsarus, here is your Magento Instance: https://3f9348cc4098a4ea0ea2d86501e9866b-2-4-develop.instances.magento-community.engineering
Admin access: https://3f9348cc4098a4ea0ea2d86501e9866b-2-4-develop.instances.magento-community.engineering/admin_98ae
Login: 212070d1
Password: 761df306c9a9

[evs-xsarus]

This diff works for me, could someone translate it to a PR?

--- magento/module-directory/Model/CountryInformationAcquirer.php
+++ magento/module-directory/Model/CountryInformationAcquirer.php
@@ -61,12 +61,12 @@
     /**
      * {@inheritdoc}
      */
-    public function getCountriesInfo()
+    public function getCountriesInfo(int $storeId = null)
     {
         $countriesInfo = [];
 
         /** @var \Magento\Store\Model\Store $store */
-        $store = $this->storeManager->getStore();
+        $store = $this->storeManager->getStore($storeId);
 
         $storeLocale = $this->scopeConfig->getValue(
             'general/locale/code',
@@ -87,9 +87,9 @@
     /**
      * {@inheritdoc}
      */
-    public function getCountryInfo($countryId)
+    public function getCountryInfo($countryId, int $storeId = null)
     {
-        $store = $this->storeManager->getStore();
+        $store = $this->storeManager->getStore($storeId);
         $storeLocale = $this->scopeConfig->getValue(
             'general/locale/code',
             \Magento\Store\Model\ScopeInterface::SCOPE_STORES,

--- magento/module-directory/Api/CountryInformationAcquirerInterface.php
+++ magento/module-directory/Api/CountryInformationAcquirerInterface.php
@@ -16,16 +16,18 @@
     /**
      * Get all countries and regions information for the store.
      *
+     * @param int|null $storeId
      * @return \Magento\Directory\Api\Data\CountryInformationInterface[]
      */
-    public function getCountriesInfo();
+    public function getCountriesInfo(int $storeId = null);
 
     /**
      * Get country and region information for the store.
      *
      * @param string $countryId
+     * @param int|null $storeId
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      * @return \Magento\Directory\Api\Data\CountryInformationInterface
      */
-    public function getCountryInfo($countryId);
+    public function getCountryInfo($countryId, int $storeId = null);
 }

[mrtuvn]

Can you create PR for this ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 28 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[evs-xsarus]

@mrtuvn I don't have experience with it, could you guide me?

[mrtuvn]

https://devdocs.magento.com/contributor-guide/contributing.html
here is the guide