Catalog Price Rule with Condition Not / Is Not One Of / Does not Contain are not applied to products without a value - and there is no "undefined" condition

[iphigenie]

When trying to use a negative condition on a promotional rule, it will not match any products which have no value for that attribute, even though one would expect it to. As a result promotions do not apply to products that the people creating the conditions would expect them to apply to.

The same happens to category conditions - see issue #32734 and I suspect it is the same query logic behind the scenes

There is a workaround for "dropdown" type attributes in that the "undefined" option exists and one can therefore combine "not ..." or "undefined" to get the result we want. There is no such option for multiselect or categories.

Preconditions (*)

1. This was tested on 2.4.2
2. products with a dropdown or multiselect attribute set to be usable for promotion rules - I have used bags in the demo data and the attribute "activities".
3. modify the "overnight duffle" to only have activity "overnight" (useful if you want to test "one of" and "not one of")
4. check that joust duffle back has no activity set (in my vanilla install, it was blank)

Steps to reproduce (*)

1. Validation: create a catalog product rule for products with the condition "contains overnight" to check the data is behaving correctly. Apply, reindex, clear caches, check it is behaves as expected and all 4 products have the special price
2. Change the rule to "does not contain overnight". Apply, reindex, clear caches, reload page

Expected result (*)

1. You would expect to see the "reverse" of the previous selection, all products have special price except for the 4 with the attribute option set. Including the one where the attribute isn't set.

Actual result (*)

1. The rule has not applied to the product where the attribute isn't set.

The same thing happens with "is not one of" - it also happens to similar conditions on CATEGORIES and it also happens on the "is not" for a DROPDOWN attribute.

Obviously this example uses the demo content and it doesn't seem as if one would want to create such a condition, but there are many cases where one might want to exclude products based on an attribute. In my case the "the promotion isn't applying to products we'd expect it to apply to" came up several times before we figured it out.

It is very possible that this is the only reasonably efficient way that these conditions can work, but if it is the case a condition "attribute has no set value" and "no category set" should exist to allow for working around it.

For the dropdown attribute this exists as the condition "is undefined" - there is no equivalent for a multiselect as there is no "undefined" option.

If the logic for these criteria can't change, then an "undefined" condition option should be created and made available for multiselect conditions and "uncategorised" for category conditions and people can combine them to get the results we need

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [x ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @iphigenie. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Oscar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[iphigenie]

HI @engcom-Oscar

It is possible that this is the only reasonably efficient way that these conditions can work, but if it is the case a condition "attribute has no set value" and "no category set" should exist to allow for working around it.

For the dropdown attribute this exists as the condition "is undefined" - there is no equivalent for a multiselect as there is no "undefined" option.

If the logic for these criteria can't change, then an "undefined" condition option should be created and made available for multiselect conditions and "uncategorised" for category conditions and people can combine them to get the results we need

Perhaps the internal task is "create missing undefined conditions for multiselect and categories"

[magento-engcom-team]

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-42005 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.