Closed
Description
This issue is automatically created based on existing pull request: #32814: Fix a PHP error being thrown on a Magento error being thrown
Description (*)
I ran into a small problem with the product media (because my pub/media wasn't writable). But I did not get the actual error that is thrown, I got a PHP error because 'directory' was not set (as you can see by my fix).
I thought, why not have my first contribution be a simple fix
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
- Have a simple magento shop with X (might as well be 1) product including images
- Change the pub/media to incorrect permissions/owners
- Try to visit the product detail page in the backend
Questions or comments
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
The issue has been fixed in 2.4-develop branchGate 3 Passed. Manual verification of the issue completed. Issue is confirmedA defect with this priority could have functionality issues which are not to expectations.The issue has been reproduced on latest 2.4-develop branchAffects non-critical data or functionality and does not force users to employ a workaround.
Type
Projects
Status
Pull Request In Progress