GraphQL Product Visibility

[DanieliMi]

Summary (*)

I am wondering about the $isChildSearch parameter here it seems very inconsistent to me. The DataProvider is used to get a product list and if it is a "child search" then it should consider the visibility of the product. But this paratmeter is only true when you try to query product links (related, upsell and crosssell). On top of it the if was changed 8ff8dbe which does not seem to actually to what is is intendet too. According to the implemented test is it supposed to take the status into account but in the code only the visibility is added. I think it only works implicitly (or by chance).

Examples (*)

When I query a product that is set to visibility 1 then I do receive it with the according visibility:

{
    products(filter: {sku: {eq: "SOME_SKU"}})
    {
        items {
            sku
            visibility
        }
    }
}

Result:
{
    "data": {
        "products": {
            "items": [
                {
                    "sku": "SOME_SKU",
                    "visibility": 1
                }
            ]
        }
    }
}

But when this product with visibility 1 is a related product to another product it will not be returned due to the visibility:

{
    products(filter: {sku: {eq: "SOME_OTHER_SKU"}})
    {
        items {
            sku
            visibility
            related_products
            {
                sku
                visibility
            }
        }
    }
}

Result:
{
    "data": {
        "products": {
            "items": [
                {
                    "sku": "SOME_OTHER_SKU",
                    "visibility": 4
                    "related_products": []
                }
            ]
        }
    }
}

Proposed solution

I think this is very inconsistent and we should either completely manage the visibility in the backend or frontend but not both.
My recommendation would be to handle it in the frontend and remove the following lines: https://github.com/magento/magento2/blob/2.4.3-p1/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/Product.php#L92-L97

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @DanieliMi. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-November]

Verified the behavior on Magento 2.4-develop branch and field "visibility" is not available for products query as per official magento docs. Hence labeling this as feature request