Unsecured URLs returned for product images

[jakwinkler]

Preconditions (*)

1. Magento 2.4.2 / 2.4.3
2. Magento 2.3.x
3. Multistore installation with following setup:
   -- store nr 1 has different URLs for media
   -- store nr 2 has only secured URL for media different
4. set secure URLs to be used in frontend

Steps to reproduce (*)

1. create a CLI method to iterate through all the stores and try to fetch main product image for each store

        /** @var \Magento\Store\Api\Data\StoreInterface $store */
        foreach ($this->storeManager->getStores() as $store) {
            foreach ($this->storeManager->getStores() as $store) {
            // force store emulation for helpers and image getters
            $this->appEmulation->startEnvironmentEmulation($store->getId(), \Magento\Framework\App\Area::AREA_FRONTEND, true);

2. fetch product collection
3. display product image using imageHelper class
4. to make it easier, use the code from sitemap generation

/**
     * Get product image URL from image filename
     *
     * @param string $image
     * @return string
     */
    private function getProductImageUrl(string $image): string
    {
        return $this->imageUrlBuilder->getUrl($image, 'product_page_image_large');
    }

Expected result (*)

1. image URLs for all product images are per configured URL

Actual result (*)

1. Media URL for each product is set to the default one

Source of the issue (*)

1. in this file vendor/magento/module-catalog/Model/Product/Media/Config.php there is no isSecure check
2. so it returns the same media URLs for all products

Solution (*)

1. issue can be solved with proper store configuration
2. introduce code fix to check if secure frontend is used for that media path

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @qsolutions-pl. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @qsolutions-pl,

Thanks for reporting the issue!

We request you to please elaborate below on the point from the main description. Screenshot will also help us in reproduction:

3. Multistore installation with following setup:
-- store nr 1 has different URLs for media
-- store nr 2 has only secured URL for media different

Thanks

[jakwinkler]

I'll provide some screenshots, but the error is clear in the file I've listed.

[jakwinkler]

I'll provide some screenshots, but the error is clear in the file I've listed.

[engcom-Hotel]

Hi @qsolutions-pl,

Thanks for your reply!

We are waiting for your reply.

Thanks

[jakwinkler]

Main Default STORE:

Second store config:

Like I've said, it can be fixed (bug will not show) with a simple configuration update by placing proper URLs into the configuration, but I still believe this is a bug because the class for generating images does not check the is_secure configuration param.

[engcom-Hotel]

Hello @qsolutions-pl,

Thanks for your reply!

We have tried to reproduce the issue, below steps we have followed:
Steps

1. Create multistore:

2. Setup different base url for main and another store:
   Main Store
   

Another Store

3. Create a CLI module to get image URL for another store:

You can see in the 2nd step, the configuration is proper for another store, still we are getting unsecured URL. Please have a look into below screenshot for reference:

Let us know in case we have missed anything.

Thanks

[jakwinkler]

So you have reproduced the issue :-)
The problem is that with such settings Use Secure URL in Frontend you should get HTTPS link not HTTP