Magento 2.4.4 - Core Unit Tests Failing

[samjack28361]

Preconditions and environment

When running Magento core unit tests, we receive the following results:

vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist

Magento 2.4.4:
Tests: 27205, Assertions: 74210, Errors: 5, Failures: 193, Warnings: 16, Skipped: 232, Incomplete: 51.

We also tried running the core unit tests on a fresh Magento 2.4.6 instance:
Tests: 27771, Assertions: 75627, Errors: 161, Failures: 31, Warnings: 31, Skipped: 296.

Looking through some of the tests that are failing, some of them seem to be written incorrectly. The following is an example of one of these tests for 2.4.4:

193) Magento\Framework\Setup\Test\Unit\ListsTest::testGetTimezoneList
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'Australia/Darwin'
     1 => 'America/Los_Angeles'
-    2 => 'Europe/Kiev'
     3 => 'Asia/Jerusalem'
 )

In this particular test, "Europe/Kiev" is missing from the expected result, and the reason why it is failing is because the timezone list returns "Europe/Kyiv" instead of "Europe/Kiev":

America/Eirunepe , America/Rio_Branco , Asia/Kabul , America/Anchorage , America/Juneau , America/Metlakatla , America/Nome , America/Sitka , America/Yakutat , America/Boa_Vista , America/Campo_Grande , America/Cuiaba , America/Manaus , America/Porto_Velho , Asia/Anadyr , Pacific/Apia , Asia/Aden , Asia/Baghdad , Asia/Bahrain , Asia/Kuwait , Asia/Qatar , Asia/Riyadh , America/Argentina/Buenos_Aires , America/Argentina/Catamarca , America/Argentina/Cordoba , America/Argentina/Jujuy , America/Argentina/La_Rioja , America/Argentina/Mendoza , America/Argentina/Rio_Gallegos , America/Argentina/Salta , America/Argentina/San_Juan , America/Argentina/San_Luis , America/Argentina/Tucuman , America/Argentina/Ushuaia , Asia/Yerevan , America/Anguilla , America/Antigua , America/Aruba , America/Barbados , America/Blanc-Sablon , America/Curacao , America/Dominica , America/Glace_Bay , America/Goose_Bay , America/Grenada , America/Guadeloupe , America/Halifax , America/Kralendijk , America/Lower_Princes , America/Marigot , America/Martinique , America/Moncton , America/Montserrat , America/Port_of_Spain , America/Puerto_Rico , America/Santo_Domingo , America/St_Barthelemy , America/St_Kitts , America/St_Lucia , America/St_Thomas , America/St_Vincent , America/Thule , America/Tortola , Atlantic/Bermuda , Australia/Adelaide , Australia/Broken_Hill , Australia/Darwin , Australia/Eucla , Antarctica/Macquarie , Australia/Brisbane , Australia/Hobart , Australia/Lindeman , Australia/Melbourne , Australia/Sydney , Australia/Perth , Asia/Baku , Atlantic/Azores , Asia/Dhaka , Asia/Thimphu , America/La_Paz , America/Araguaina , America/Bahia , America/Belem , America/Fortaleza , America/Maceio , America/Recife , America/Santarem , America/Sao_Paulo , Asia/Brunei , Atlantic/Cape_Verde , Antarctica/Casey , Africa/Blantyre , Africa/Bujumbura , Africa/Gaborone , Africa/Harare , Africa/Juba , Africa/Khartoum , Africa/Kigali , Africa/Lubumbashi , Africa/Lusaka , Africa/Maputo , Africa/Windhoek , Africa/Algiers , Africa/Ceuta , Africa/Tunis , Arctic/Longyearbyen , Europe/Amsterdam , Europe/Andorra , Europe/Belgrade , Europe/Berlin , Europe/Bratislava , Europe/Brussels , Europe/Budapest , Europe/Busingen , Europe/Copenhagen , Europe/Gibraltar , Europe/Ljubljana , Europe/Luxembourg , Europe/Madrid , Europe/Malta , Europe/Monaco , Europe/Oslo , Europe/Paris , Europe/Podgorica , Europe/Prague , Europe/Rome , Europe/San_Marino , Europe/Sarajevo , Europe/Skopje , Europe/Stockholm , Europe/Tirane , Europe/Vaduz , Europe/Vatican , Europe/Vienna , Europe/Warsaw , Europe/Zagreb , Europe/Zurich , Asia/Makassar , America/Bahia_Banderas , America/Belize , America/Chicago , America/Chihuahua , America/Costa_Rica , America/El_Salvador , America/Guatemala , America/Indiana/Knox , America/Indiana/Tell_City , America/Managua , America/Matamoros , America/Menominee , America/Merida , America/Mexico_City , America/Monterrey , America/North_Dakota/Beulah , America/North_Dakota/Center , America/North_Dakota/New_Salem , America/Ojinaga , America/Rankin_Inlet , America/Regina , America/Resolute , America/Swift_Current , America/Tegucigalpa , America/Winnipeg , Pacific/Guam , Pacific/Saipan , Pacific/Chatham , America/Santiago , Asia/Macau , Asia/Shanghai , Indian/Christmas , Pacific/Chuuk , Indian/Cocos , America/Bogota , Pacific/Rarotonga , UTC , America/Havana , Antarctica/Davis , Antarctica/DumontDUrville , Africa/Addis_Ababa , Africa/Asmara , Africa/Dar_es_Salaam , Africa/Djibouti , Africa/Kampala , Africa/Mogadishu , Africa/Nairobi , Indian/Antananarivo , Indian/Comoro , Indian/Mayotte , America/Scoresbysund , Asia/Almaty , Asia/Qostanay , Asia/Dili , Pacific/Easter , Africa/Cairo , Africa/Tripoli , Asia/Beirut , Asia/Gaza , Asia/Hebron , Asia/Nicosia , Europe/Athens , Europe/Bucharest , Europe/Chisinau , Europe/Helsinki , Europe/Kaliningrad , Europe/Kyiv , Europe/Mariehamn , Europe/Riga , Europe/Sofia , Europe/Tallinn , Europe/Vilnius , Asia/Jayapura , America/Atikokan , America/Cancun , America/Cayman , America/Detroit , America/Grand_Turk , America/Indiana/Indianapolis , America/Indiana/Marengo , America/Indiana/Petersburg , America/Indiana/Vevay , America/Indiana/Vincennes , America/Indiana/Winamac , America/Iqaluit , America/Jamaica , America/Kentucky/Louisville , America/Kentucky/Monticello , America/Nassau , America/New_York , America/Panama , America/Port-au-Prince , America/Toronto , America/Guayaquil , Atlantic/Stanley , America/Noronha , Pacific/Fiji , America/Cayenne , Indian/Kerguelen , Africa/Casablanca , Africa/El_Aaiun , Asia/Famagusta , Asia/Amman , Asia/Damascus , Europe/Istanbul , Europe/Kirov , Europe/Astrakhan , Europe/Saratov , Europe/Ulyanovsk , Asia/Urumqi , Asia/Barnaul , Asia/Tomsk , Asia/Srednekolymsk , Pacific/Bougainville , America/Punta_Arenas , Antarctica/Palmer , Pacific/Galapagos , Pacific/Gambier , Asia/Tbilisi , Pacific/Tarawa , Africa/Abidjan , Africa/Accra , Africa/Bamako , Africa/Banjul , Africa/Bissau , Africa/Conakry , Africa/Dakar , Africa/Freetown , Africa/Lome , Africa/Monrovia , Africa/Nouakchott , Africa/Ouagadougou , Africa/Sao_Tome , America/Danmarkshavn , Antarctica/Troll , Atlantic/Reykjavik , Atlantic/St_Helena , Europe/Dublin , Europe/Guernsey , Europe/Isle_of_Man , Europe/Jersey , Europe/London , Asia/Dubai , Asia/Muscat , America/Guyana , America/Adak , Pacific/Honolulu , Asia/Hong_Kong , Asia/Hovd , Asia/Colombo , Asia/Kolkata , Indian/Chagos , Asia/Bangkok , Asia/Ho_Chi_Minh , Asia/Phnom_Penh , Asia/Vientiane , Asia/Tehran , Asia/Irkutsk , Asia/Jerusalem , Asia/Tokyo , Asia/Pyongyang , Asia/Seoul , Pacific/Kosrae , Asia/Krasnoyarsk , Asia/Novokuznetsk , Asia/Bishkek , Pacific/Kiritimati , Australia/Lord_Howe , Asia/Magadan , Asia/Kuala_Lumpur , Asia/Kuching , Indian/Maldives , Pacific/Marquesas , Pacific/Kwajalein , Pacific/Majuro , Indian/Mauritius , Antarctica/Mawson , America/Hermosillo , America/Mazatlan , Europe/Minsk , Europe/Moscow , Europe/Simferopol , America/Boise , America/Cambridge_Bay , America/Ciudad_Juarez , America/Creston , America/Dawson_Creek , America/Denver , America/Edmonton , America/Fort_Nelson , America/Inuvik , America/Phoenix , America/Yellowknife , Asia/Yangon , Pacific/Nauru , Asia/Kathmandu , Pacific/Noumea , Antarctica/McMurdo , Pacific/Auckland , America/St_Johns , Pacific/Niue , Pacific/Norfolk , Asia/Novosibirsk , Asia/Omsk , America/Los_Angeles , America/Tijuana , America/Vancouver , Asia/Karachi , Pacific/Palau , Pacific/Port_Moresby , America/Asuncion , America/Lima , Asia/Kamchatka , Asia/Manila , Pacific/Kanton , Pacific/Pitcairn , Pacific/Pohnpei , Antarctica/Rothera , Indian/Reunion , Asia/Sakhalin , Europe/Samara , Pacific/Midway , Pacific/Pago_Pago , Indian/Mahe , Asia/Singapore , Pacific/Guadalcanal , Africa/Johannesburg , Africa/Maseru , Africa/Mbabane , Atlantic/South_Georgia , America/Miquelon , America/Paramaribo , Antarctica/Syowa , Pacific/Tahiti , Asia/Taipei , Asia/Dushanbe , Pacific/Fakaofo , Pacific/Tongatapu , Asia/Ashgabat , Pacific/Funafuti , Asia/Choibalsan , Asia/Ulaanbaatar , America/Montevideo , Asia/Samarkand , Asia/Tashkent , Pacific/Efate , America/Caracas , Asia/Ust-Nera , Asia/Vladivostok , Europe/Volgograd , Antarctica/Vostok , Pacific/Wake , Pacific/Wallis , Africa/Bangui , Africa/Brazzaville , Africa/Douala , Africa/Kinshasa , Africa/Lagos , Africa/Libreville , Africa/Luanda , Africa/Malabo , Africa/Ndjamena , Africa/Niamey , Africa/Porto-Novo , America/Nuuk , Asia/Aqtau , Asia/Aqtobe , Asia/Atyrau , Asia/Oral , Asia/Qyzylorda , Atlantic/Canary , Atlantic/Faroe , Atlantic/Madeira , Europe/Lisbon , Asia/Jakarta , Asia/Pontianak , Asia/Chita , Asia/Khandyga , Asia/Yakutsk , Asia/Yekaterinburg , America/Dawson , America/Whitehorse

Note that the above unit test is just an example that I pulled from the list of test failures. This specific test has been fixed in 2.4.6, so it does seem like the Magento team is actively trying to fix their own unit tests.

Is there a standard process to fix tests such as these? We don't want to modify the core test file, and using either preferences or plugins do not work. Should we bother trying to fix them?

Steps to reproduce

1. Run vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist

Expected result

Core unit tests run successfully.

Actual result

Core unit tests do not run successfully:

Magento 2.4.4:
Tests: 27205, Assertions: 74210, Errors: 5, Failures: 193, Warnings: 16, Skipped: 232, Incomplete: 51.

Fresh Magento 2.4.6 instance:
Tests: 27771, Assertions: 75627, Errors: 161, Failures: 31, Warnings: 31, Skipped: 296.

Additional information

We are running these tests using a Macbook Pro, M1 chip, arm64.

For 2.4.6

For 2.4-develop

Please also find the actual failures during unit tests run:
2-4-6.UnitTestFailures.log
2-4-develop.UnitTestFailures.log

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @samjack28361. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @samjack28361,

Thanks for the report and collaboration!

We have tried to reproduce the issue in Magento 2.4-develop branch and 2.4.6 (latest version), and it seems the issue is reproducible for us:

Please have a look into the below screenshots for reference;

For 2.4.6

For 2.4-develop

Please also find the actual failures during unit tests run:
2-4-6.UnitTestFailures.log
2-4-develop.UnitTestFailures.log

Hence confirming the issue.

Thanks