magento/magento2#37803: Customer order filters graphql #38079

serbynskyi · 2023-10-13T15:26:11Z

Description (*)

Fixed Issue

Fixes customer order filters graphql #37803

Manual testing scenarios (*)

1.Create a new Module CustomerOrder.
2.Create a schema.graphqls in Teeela/CustomerOrder/etc/ folder to extend the CustomerOrderFilterInput.
Put following codes in this file:

input CustomerOrdersFilterInput @doc(description: "Identifies the filter to use for filtering orders.") {
number: FilterStringTypeInput @doc(description: "Filters by order number.")
created_at: FilterRangeTypeInput @doc(description: "Filters by created at.")
status: FilterEqualTypeInput @doc(description: "Filters by status.")
}

input FilterRangeTypeInput @doc(description: "Defines a filter that matches a range of values, such as prices or dates.") {
from: String @doc(description: "The beginning of the range")
to: String @doc(description: "The end of the range")
}

input FilterEqualTypeInput @doc(description: "Defines a filter that matches the input exactly.") {
in: [String] @doc(description: "An array of values to filter on")
eq: String @doc(description: "A string to filter on")
}
3.Use the following payload and {{your URL}}/graphql to query the customer token.

mutation {
generateCustomerToken(email: "{{your email address}}", password: "{{your password}}") {
token
}
}
4.Put above token in Postman Headers Authorization with Bearer {{your token}}.
5.Use following payload to query the above customer's sales orders.

query {
customer {
orders(filter: { created_at: { from: "2023-07-22" } status:{ in:["Processing"]} })
{
items {
number
created_at
}
}
}


Result:
orders from 2023-07-22 and status Processing

### Contribution checklist (*)
 - [ ] Pull request has a meaningful description of its purpose
 - [ ] All commits are accompanied by meaningful commit messages
 - [ ] All new or changed code is covered with unit/integration tests (if applicable)
 - [ ] README.md files for modified modules are updated and included in the pull request if any [README.md predefined sections](https://github.com/magento/devdocs/wiki/Magento-module-README.md) require an update
 - [ ] All automated tests passed successfully (all builds are green)


### Resolved issues:
1. [x] resolves magento/magento2#38371: magento/magento2#37803: Customer order filters graphql

### Resolved issues:
1. [x] resolves magento/magento2#38372: magento/magento2#37803: Customer order filters graphql

m2-assistant · 2023-10-13T15:26:15Z

Hi @serbynskyi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

shikhamis11 · 2023-10-15T02:56:23Z

@magento run all tests

magento-automated-testing · 2023-10-15T02:56:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

shikhamis11 · 2023-10-15T03:07:53Z

@serbynskyi thank you for your Pull request. Can you also cover your changes with the web API function test?

venchiarutti · 2023-10-19T14:43:04Z

Hey! take a look at this one: #36949 @serbynskyi

engcom-Hotel · 2023-11-20T05:59:33Z

@magento run all tests

magento-automated-testing · 2023-11-20T05:59:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-11-20T09:55:02Z

@magento run WebAPI Tests, Static Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2023-11-20T09:55:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-11-20T11:58:31Z

@magento run Functional Tests CE

magento-automated-testing · 2023-11-20T11:58:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel

Hello @serbynskyi,

Thanks for the contribution!

The Changes looks good to me and the failed test seems flaky to me. But please cover the changes with some automated test in accordance with DOD.

Thanks

engcom-Charlie · 2023-12-13T13:21:11Z

Working on web API test coverage.

engcom-Echo · 2024-01-23T06:46:35Z

@magento create issue

andrewbess

Hello @serbynskyi
Thank you for contribution
Looks good for me
Approved

engcom-Echo · 2024-01-23T07:55:18Z

@magento run all tests

magento-automated-testing · 2024-01-23T07:55:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

andrewbess · 2024-01-23T08:51:58Z

@magento create issue

Hello @engcom-Echo
The issue has already created (#37803)
Let's avoid to create redundant ones

I'll close last one

engcom-Echo · 2024-01-23T09:52:32Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenario:

We have follow steps from comment

Before: ✖️

After: ✔️

Builds are failing. Hence moving it to Extended Testing

andrewbess · 2024-01-23T09:57:54Z

Hey guys.
Sorry, but I missed one comment in this PR
It looks we already have a similar PR

Which PR we need to choice for merging?
I think it should be #36949

it was created earlier
it is more relevant due to has fixes for graphql.schema

What do you think @engcom-Hotel @engcom-Echo @shikhamis11 about my suggestion?

andrewbess · 2024-01-23T10:07:13Z

Hey guys. Sorry, but I missed one comment in this PR It looks we already have a similar PR

Which PR we need to choice for merging? I think it should be #36949

it was created earlier

it is more relevant due to has fixes for graphql.schema

What do you think @engcom-Hotel @shikhamis11 about my suggestion?

or we can combine both PRs

magento-automated-testing · 2024-01-23T13:21:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2024-01-24T06:24:02Z

Hi @andrewbess,

Thank you for the information

We will take #36949 PR further as the schema changes are in place.

Till then keeping this PR to On Hold until #36949 will get merge.

Thank you!

engcom-Charlie · 2024-06-03T06:37:55Z

As mentioned in this comment, the required changes has been taken care in #36949 and it got merged in 0a41d1a hence closing this PR now.

magento#37803: Customer order filters graphql

5cf1281

m2-github-services added Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner labels Oct 13, 2023

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Oct 13, 2023

Merge branch '2.4-develop' into fix-for-issue-37803

008e46a

shikhamis11 self-requested a review October 15, 2023 02:55

sinhaparul added the Project: Community Picked PRs upvoted by the community label Nov 17, 2023

Merge branch '2.4-develop' into fix-for-issue-37803

7f762dd

engcom-Hotel self-requested a review November 20, 2023 06:17

m2-community-project bot added Progress: review and removed Progress: pending review labels Nov 20, 2023

engcom-Hotel requested changes Nov 21, 2023

View reviewed changes

m2-community-project bot assigned engcom-Hotel Nov 21, 2023

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 21, 2023

engcom-Charlie self-assigned this Dec 6, 2023

Adding web API test coverage

1a7aaf2

m2-community-project bot added the Progress: ready for testing label Jan 22, 2024

m2-assistant bot mentioned this pull request Jan 23, 2024

[Issue] magento/magento2#37803: Customer order filters graphql #38371

Closed

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Jan 23, 2024

andrewbess approved these changes Jan 23, 2024

View reviewed changes

m2-community-project bot assigned andrewbess Jan 23, 2024

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Jan 23, 2024

Merge branch '2.4-develop' into fix-for-issue-37803

455c593

engcom-Echo self-assigned this Jan 23, 2024

m2-assistant bot mentioned this pull request Jan 23, 2024

[Issue] magento/magento2#37803: Customer order filters graphql #38372

Closed

m2-community-project bot added Progress: testing in progress Progress: extended testing and removed Progress: ready for testing Progress: testing in progress labels Jan 23, 2024

andrewbess mentioned this pull request Jan 23, 2024

Adding created_at, status and grand_total filters to customer Orders query and fixing multiple filters failure #36949

Merged

5 tasks

m2-community-project bot added Progress: on hold and removed Progress: extended testing labels Jan 24, 2024

engcom-Charlie closed this Jun 3, 2024

m2-community-project bot removed the Progress: on hold label Jun 3, 2024

magento/magento2#37803: Customer order filters graphql #38079

magento/magento2#37803: Customer order filters graphql #38079

Uh oh!

Conversation

serbynskyi commented Oct 13, 2023 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issue

Manual testing scenarios (*)

Uh oh!

m2-assistant bot commented Oct 13, 2023

Uh oh!

shikhamis11 commented Oct 15, 2023

Uh oh!

magento-automated-testing bot commented Oct 15, 2023

Uh oh!

shikhamis11 commented Oct 15, 2023

Uh oh!

venchiarutti commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Hotel commented Nov 20, 2023

Uh oh!

magento-automated-testing bot commented Nov 20, 2023

Uh oh!

engcom-Hotel commented Nov 20, 2023

Uh oh!

magento-automated-testing bot commented Nov 20, 2023

Uh oh!

engcom-Hotel commented Nov 20, 2023

Uh oh!

magento-automated-testing bot commented Nov 20, 2023

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Dec 13, 2023

Uh oh!

engcom-Echo commented Jan 23, 2024

Uh oh!

andrewbess left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Echo commented Jan 23, 2024

Uh oh!

magento-automated-testing bot commented Jan 23, 2024

Uh oh!

andrewbess commented Jan 23, 2024

Uh oh!

engcom-Echo commented Jan 23, 2024

✔️ QA Passed

Uh oh!

andrewbess commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewbess commented Jan 23, 2024

Uh oh!

magento-automated-testing bot commented Jan 23, 2024

Uh oh!

engcom-Charlie commented Jan 24, 2024

Uh oh!

engcom-Charlie commented Jun 3, 2024

Uh oh!

Uh oh!

serbynskyi commented Oct 13, 2023 •

edited by m2-assistant bot

Loading

venchiarutti commented Oct 19, 2023 •

edited

Loading

andrewbess commented Jan 23, 2024 •

edited

Loading