Adding created_at, status and grand_total filters to customer Orders query and fixing multiple filters failure #36949

venchiarutti · 2023-03-02T22:35:35Z

Description (*)

Added created_at, status, and grand_total filters to customer Orders query
Fixing multiple filters bug in this query, when adding one more filter in the array for filterGroupBuilder addFilters it doesn´t apply all filters

Related Pull Requests

Fixed Issues (if relevant)

Fixes Added created_at, status and grand_total filters to customer Orders query and fixed multiple filters failure #38392

Manual testing scenarios (*)

Create an order with a customer
With the same customer, generate a customer token and call the customer Orders query
Create multiple orders to test filters
Use two or more filters to check if multiple are being applied

Questions or comments

I did not find a unit test for this class, does it exist?

I used the same names from the output object to maintain the pattern

I accept any suggestions or critics, doing it you are helping me!

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…query and fixing multiple filters failure

m2-assistant · 2023-03-02T22:35:38Z

Hi @venchiarutti. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

magento-automated-testing · 2023-03-03T12:25:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-03-03T12:58:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

venchiarutti · 2023-03-08T02:36:42Z

@magento run all tests

magento-automated-testing · 2023-03-08T02:36:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…into venchiarutti-patch-1

…i/magento2 into venchiarutti-patch-1

andrewbess · 2024-01-23T07:00:28Z

@magento run all tests

magento-automated-testing · 2024-01-23T07:00:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

andrewbess

Hello @venchiarutti
Thank you for your collaboration
Waiting for tests and answers on this question

andrewbess · 2024-01-23T08:47:14Z

@magento run Static Tests

magento-automated-testing · 2024-01-23T08:47:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2024-01-25T06:32:19Z

@magento run Static Tests

magento-automated-testing · 2024-01-25T06:32:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2024-01-29T10:17:13Z

@magento create issue

venchiarutti · 2024-01-30T20:32:53Z

@magento run Static Tests

magento-automated-testing · 2024-01-30T20:33:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

venchiarutti · 2024-01-31T19:00:25Z

I don't know what may be causing these errors in the tests, I would appreciate some help @engcom-Charlie

engcom-Charlie · 2024-02-26T05:57:38Z

@magento run all tests

engcom-Charlie · 2024-03-20T07:42:06Z

@magento run all tests

engcom-Charlie · 2024-03-20T10:00:05Z

@magento run Static Tests, Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

engcom-Charlie · 2024-03-20T10:29:18Z

@magento run all tests

engcom-Charlie · 2024-03-21T06:34:33Z

@magento run Functional Tests B2B, Functional Tests EE

engcom-Charlie · 2024-03-21T10:04:18Z

The functional B2B and Functional EE test failures are different in recent 2 runs. It seems to be flaky. Hence moving this PR to testing.

Functional B2B
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/d4a8ff37aa03dfb6987d30b2264a5268/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/783d2df354d1f5891f44661b8136c7f9/Functional/allure-report-b2b/index.html#categories/3ae677d8e6673a8efa39994732ea996b/e4d89e84c1a662bd/

Functional EE
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/c6e6aee0a48a64b0fe33c877033b1d27/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/0a5681974428b092ccbc5ded0d4501a1/Functional/allure-report-ee/index.html#categories

engcom-Delta · 2024-04-05T09:05:46Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenario:

1.Create an order with a customer
2.With the same customer, generate a customer token and call the customer Orders query
3.Create multiple orders to test filters
4.Use two or more filters to check if multiple are being applied

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Charlie · 2024-04-05T09:10:02Z

@magento run all tests

engcom-Charlie · 2024-04-08T06:50:33Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

engcom-Charlie · 2024-04-08T09:06:24Z

The functional B2B failures except AdminAssignCompaniesTest and AdminCompanyRelationsInCompanyIndexGridTest are different in recent 2 builds. For these 2, there are open issues ACQE-6363, ACQE-6364

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/b0b53ee1a20af547cafe51557850f139/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/c5bd3507dbdbfafb123d6980ad97e9fc/Functional/allure-report-b2b/index.html#categories/e847f4a0aaffc342329492c79cacfbad/f4a8a69b474f25f5/

Functional CE failures are different in recent 2 builds. Seems to be flaky.
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/b8191553fb821607f8ccec58e3f9e147/Functional/allure-report-ce/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/3540509c851b511bcf235def01f86df1/Functional/allure-report-ce/index.html#categories

engcom-Charlie · 2024-04-08T09:07:05Z

@magento run Functional Tests EE

engcom-Charlie · 2024-04-08T09:16:54Z

The functional EE failures are differnt in latest 2 builds except StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest. This bug its not occurring because of this PR and also there is an open issue exists. Moving this PR to Merge in Progress now.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/8a5e351fb6e507c18fe127e5ae5ce933/Functional/allure-report-ee/index.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36949/1297e6f1175a02d898c53c12b33c1e0d/Functional/allure-report-ee/index.html#categories

Adding created_at, status and grand_total filters to customer Orders …

c19acc9

…query and fixing multiple filters failure

Fixing grand_total doc in schema graphql

3654742

engcom-Charlie added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 7, 2023

m2-community-project bot added the Progress: pending review label Mar 7, 2023

venchiarutti and others added 4 commits March 10, 2023 14:30

Merge branch '2.4-develop' into venchiarutti-patch-1

4128797

Merge branch '2.4-develop' of https://github.com/venchiarutti/magento2 …

970d14b

…into venchiarutti-patch-1

Merge branch 'venchiarutti-patch-1' of https://github.com/venchiarutt…

8b3fbd0

…i/magento2 into venchiarutti-patch-1

Merge branch '2.4-develop' into venchiarutti-patch-1

e5c4444

venchiarutti mentioned this pull request Oct 19, 2023

magento/magento2#37803: Customer order filters graphql #38079

Closed

Merge branch '2.4-develop' into venchiarutti-patch-1

447e38f

andrewbess self-assigned this Jan 23, 2024

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 23, 2024

andrewbess requested changes Jan 23, 2024

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 23, 2024

engcom-Charlie self-assigned this Jan 25, 2024

m2-assistant bot mentioned this pull request Jan 29, 2024

Added created_at, status and grand_total filters to customer Orders query and fixed multiple filters failure #38392

Closed

5 tasks

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Jan 30, 2024

Merge branch '2.4-develop' into venchiarutti-patch-1

187682b

Merge branch '2.4-develop' into venchiarutti-patch-1

f664adc

Fixing static test failure

3ca0e6b

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Mar 21, 2024

engcom-Delta added Progress: testing in progress and removed Progress: ready for testing labels Apr 4, 2024

engcom-Delta added Progress: extended testing and removed Progress: testing in progress labels Apr 5, 2024

Merge branch '2.4-develop' into venchiarutti-patch-1

b015f9d

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Apr 8, 2024

magento-devops-reposync-svc merged commit 0a41d1a into magento:2.4-develop May 16, 2024

Adding created_at, status and grand_total filters to customer Orders query and fixing multiple filters failure #36949

Adding created_at, status and grand_total filters to customer Orders query and fixing multiple filters failure #36949

Uh oh!

Conversation

venchiarutti commented Mar 2, 2023 • edited by andrewbess Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Mar 2, 2023

Uh oh!

magento-automated-testing bot commented Mar 3, 2023

Uh oh!

magento-automated-testing bot commented Mar 3, 2023

Uh oh!

venchiarutti commented Mar 8, 2023

Uh oh!

magento-automated-testing bot commented Mar 8, 2023

Uh oh!

andrewbess commented Jan 23, 2024

Uh oh!

magento-automated-testing bot commented Jan 23, 2024

Uh oh!

andrewbess left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewbess commented Jan 23, 2024

Uh oh!

magento-automated-testing bot commented Jan 23, 2024

Uh oh!

engcom-Charlie commented Jan 25, 2024

Uh oh!

magento-automated-testing bot commented Jan 25, 2024

Uh oh!

engcom-Charlie commented Jan 29, 2024

Uh oh!

venchiarutti commented Jan 30, 2024

Uh oh!

magento-automated-testing bot commented Jan 30, 2024

Uh oh!

venchiarutti commented Jan 31, 2024

Uh oh!

engcom-Charlie commented Feb 26, 2024

Uh oh!

engcom-Charlie commented Mar 20, 2024

Uh oh!

engcom-Charlie commented Mar 20, 2024

Uh oh!

engcom-Charlie commented Mar 20, 2024

Uh oh!

engcom-Charlie commented Mar 21, 2024

Uh oh!

engcom-Charlie commented Mar 21, 2024

Uh oh!

engcom-Delta commented Apr 5, 2024

✔️ QA Passed

Uh oh!

engcom-Charlie commented Apr 5, 2024

Uh oh!

engcom-Charlie commented Apr 8, 2024

Uh oh!

engcom-Charlie commented Apr 8, 2024

Uh oh!

engcom-Charlie commented Apr 8, 2024

Uh oh!

engcom-Charlie commented Apr 8, 2024

Uh oh!

Uh oh!

venchiarutti commented Mar 2, 2023 •

edited by andrewbess

Loading

andrewbess left a comment •

edited

Loading