Skip to content

Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class #38469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class #38469

wants to merge 4 commits into from

Conversation

JDavidVR
Copy link
Contributor

@JDavidVR JDavidVR commented Feb 25, 2024 •
edited by m2-assistant bot
Loading

Description (*)

Besides:
{{block id="static_cms_block" }}
{{block id="1" }}
{{block class='\Magento\Theme\Block\Html\Footer' name='test.block' template='Magento_Theme::html/footer.phtml'}}

It also allows: {{block template='Magento_Module::html/footer.phtml'}} setting as default block: \Magento\Framework\View\Element\Template

like layout.xml is doing: https://developer.adobe.com/commerce/frontend-core/guide/layouts/xml-instructions/#block

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class #38477: Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class

@JDavidVR
Update Filter.php to allow {{block template="Magento_Module::path/to/…
0480bf1 
…template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class

Besides:
{{block id="static_cms_block" }}
{{block id="1" }}
{{block class='\Magento\Theme\Block\Html\Footer' name='test.block' template='Magento_Theme::html/footer.phtml'}}

It also allows: 
{{block template='Magento_Module::html/footer.phtml'}}

setting as default block: \Magento\Framework\View\Element\Template

like  layout.xml is doing:  \Magento\Framework\View\Element\Template
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Feb 25, 2024

Hi @JDavidVR. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@mrtuvn mrtuvn added Component: Email Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Feb 25, 2024
@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 25, 2024

can you describe more about the reason of this update ? and also add some test case for coverage your changes

@andrewbess
Copy link
Contributor

andrewbess commented Feb 25, 2024 •
edited by engcom-Hotel
Loading

Hello @JDavidVR
Thank you for your contribution.
Could you please sign Adobe CLA?
Thank you in advance.

@JDavidVR
Copy link
Contributor Author

@andrewbess I've already signed the Adobe CLA

Not sure why it is not updated

image image

@JDavidVR
Copy link
Contributor Author

@mrtuvn this change allows to call templates files in cms_pages & cms_blocks

For ex. {{block template='Magento_Module::template/file.phtml'}} instead of {{block class= ' \Magento\Framework\View\Element\Template' template='Magento_Module::template/file.phtml'}}

image

this change is inspired on how layout.xml is working:

image

@andrewbess andrewbess self-assigned this Feb 25, 2024
@andrewbess
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Feb 27, 2024
Open
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewbess andrewbess

Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: Email Priority: P3 May be fixed according to the position in the backlog. Progress: review
Projects
None yet
Milestone
No milestone
4 participants
@JDavidVR @mrtuvn @andrewbess @engcom-Hotel