-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Update Filter.php to allow {{block template="Magento_Module::path/to/template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class #38469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
…template.phtml"}} and setting \Magento\Framework\View\Element\Template as default class Besides: {{block id="static_cms_block" }} {{block id="1" }} {{block class='\Magento\Theme\Block\Html\Footer' name='test.block' template='Magento_Theme::html/footer.phtml'}} It also allows: {{block template='Magento_Module::html/footer.phtml'}} setting as default block: \Magento\Framework\View\Element\Template like layout.xml is doing: \Magento\Framework\View\Element\Template
Hi @JDavidVR. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
can you describe more about the reason of this update ? and also add some test case for coverage your changes |
Hello @JDavidVR |
@andrewbess I've already signed the Adobe CLA Not sure why it is not updated ![]() ![]() |
@mrtuvn this change allows to call templates files in cms_pages & cms_blocks For ex. ![]() this change is inspired on how layout.xml is working: ![]() |
@magento run all tests |
@magento create issue |
Description (*)
Besides:
{{block id="static_cms_block" }}
{{block id="1" }}
{{block class='\Magento\Theme\Block\Html\Footer' name='test.block' template='Magento_Theme::html/footer.phtml'}}
It also allows: {{block template='Magento_Module::html/footer.phtml'}} setting as default block: \Magento\Framework\View\Element\Template
like layout.xml is doing: https://developer.adobe.com/commerce/frontend-core/guide/layouts/xml-instructions/#block
Contribution checklist (*)
Resolved issues: