Display wrong price on category list and product view page

[Dhaval410]

Preconditions (*)

1. Magento version: 2.4-develop brach

Description (*)

In the store, the display prices is set as including tax. And persistent shopping cart is enabled. So, as a not logged in customer the prices display on the category list and product view page is including tax and it is correct. But when I logged in as a customer and wait for the automatically expire customer session and then it shows the excluding tax price some time on category list page and some time on product page. But after customer logout it should display including tax price on both places.

Configurations (*)

1. Create one category and create one product, assigned this product to the category.

2. Create one tax rate for one country. For example here I have created tax rate for Denmark country (see screenshot-01).
   
   screenshot-01

3. Create one tax rule and select the tax rate we created above (see screenshot-02).
   
   screenshot-02

4. Configure the 'Tax classes' and 'Default Tax Destination Calculation' as in screenshot-03.
   
   screenshot-03

5. Configure the display price every where with including tax same as below screenshot-04.
   
   screenshot-04

6. Configure Country Options. Here, Set default country for which we added the tax rate. For example I have set Denmark as default country. And allow multiple countries (Note: we must allow the country for which we added tax rate and second country for which no any tax rate configure). For example I have allowed Denmark and United State.

7. Configure 'Persistent Shopping Cart'. We need to enable persistence from the Store -> Configuration -> Customers -> Persistent Shopping Cart -> General Options -> Enable persistence

8. Configure the 'Cookie Lifetime' for small amount of time like 3 - 4 minute. So, it can be expire within given time for checking issue without wait for long time. for that Goto Store -> Configuration -> General -> Web -> Default Cookie Settings -> Cookie Lifetime

9. Create one customer and add the address with the country for which no any tax rate configured. Here I have created customer with United state country.

Steps to reproduce (*)

1. In frontend, goto category page and open product in product page, observe the price at both pages.
2. Now flush the cache by using php bin/magento cache:flush command. And logged in with the customer which have no any tax rate.
3. Goto category page again and add product to cart from category page and open that product in another tab. And observe the price at both place.
4. Stay on the category page and Wait for the customer session expire (As per the configuration cookie lifetime sets for 3 min). So, Wait for 3 min and then refresh the category page one time. Now you will see that, customer session expired.
5. Now remove that product from the mini-cart and don't refresh the page.
6. Again add that product to cart from the category page. Open that product in another tab. And refresh the category page, observe price. Also observe the price on product view page.

Expected result (*)

After following the above steps and when customer session expired, then price should display including tax as per the tax configuration.

Actual result (*)

As per the configuration, when customer is not logged in then the price is including tax. But when we use above steps and after customer session expired, then the price display excluding tax.

Additional information (*)

When you view the category list page and product view page without logged in, the category page cache and product page cache have including tax price. Please refer below screenshot-05 and screenshot-06 accordingly.

screenshot-05

screenshot-06

Now after the 6th step mention in the steps to reproduce, again check the cache report. And in the cache, it shows the excluding tax price even after logged out. Please refer below screenshot-07 and screenshot-08.

screenshot-07

screenshot-08

In the above screenshot, it shows the data from the cache key. And this cache key generates from the afterGetCacheKey() function (see screenshot-09) of the below class:

Magento/Catalog/Block/Category/Plugin/PriceBoxTags.php

screenshot-09

In the cache key the last three things represent the Store Id, Customer Group Id and Tax Rate Id.
If any tax rate applied to the customer group, tax rate id will be display at the end of the generated cache key. And if not applied then it will display as blank after underscore (_) in cache key (as in the sceershot-05 to sceernshot-08).

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Dhaval410. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

Hi @Dhaval410

Thanks for reporting and collaboration.

Verified the issue on magento 2.4 dev instance but the issue is not reproducible.

Steps to reproduce (*)
In frontend, goto category page and open product in product page, observe the price at both pages.
Now flush the cache by using php bin/magento cache:flush command. And logged in with the customer which have no any tax rate.
Goto category page again and add product to cart from category page and open that product in another tab. And observe the price at both place.
Stay on the category page and Wait for the customer session expire (As per the configuration cookie lifetime sets for 3 min). So, Wait for 3 min and then refresh the category page one time. Now you will see that, customer session expired.
Now remove that product from the mini-cart and don't refresh the page.
Again add that product to cart from the category page. Open that product in another tab. And refresh the category page, observe price. Also observe the price on product view page.

After following the above steps and the customer session expired we are seeing the price including tax as per the tax configuration.

Please refer the attached screenshots. Let us know if we missed anything.

Price after customer session expiration.

[Dhaval410]

Hi @engcom-Dash

Thanks for review and quick response.

In the steps to reproduce section I have mention to observe the price in category list page and product view page. As per your attached screenshot, it seems you are checking the price on checkout cart page.

Kindly Please make sure, the configuration of your store is same as I mention in the configuration section of the issue. Also I have attached the recorded video. Please refer it.

wrong-price-issue.mp4

[engcom-Dash]

Hi @Dhaval410

Thanks for reporting and collaboration.

Verified the issue on magento 2.4 dev instance and the issue is reproduable. Hence, confirming the issue.

Steps to reproduce (*)

1. In frontend, goto category page and open product in product page, observe the price at both pages.
2. Now flush the cache by using php bin/magento cache:flush command. And logged in with the customer which have no any tax rate.
3. Goto category page again and add product to cart from category page and open that product in another tab. And observe the price at both place.
4. Stay on the category page and Wait for the customer session expire (As per the configuration cookie lifetime sets for 3 min). So, Wait for 3 min and then refresh the category page one time. Now you will see that, customer session expired.
5. Now remove that product from the mini-cart and don't refresh the page.
6. Again add that product to cart from the category page. Open that product in another tab. And refresh the category page, observe price. Also observe the price on product view page.

As per the configuration, when customer is not logged in then the price is including tax. But when we use above steps and after customer session expired, then the price display excluding tax.

Please refer the attached screenshots.