Skip to content

[Issue] Only add 24h to toTimeStamp if no time has been given #38513

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #38496: Only add 24h to toTimeStamp if no time has been given


Description (*)

This PR updates the dateTo check to check wether the timestamp is 00:00:00 before adding 24 hours.
Ensuring the old behaviour works as expected. However allowing passing in a time without 24 hours being forced onto the date.

Manual testing scenarios (*)

  1. Execute isScopeDateInInterval() with the scope, from day, and to date only being a date
  2. Check that 24 hours has been added to the ToDate
  3. Execute isScopeDateInInterval() with the scope, from day, and to date being a date with a time
  4. Check that 24 hours has not been added and it matches the exact time given

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Labels

Area: FrameworkComponent: StdlibPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itfeature request

Type

No type

Projects

Status

Pull Request in Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions