[Performance] ProductRepository cache issue

[Nuranto]

Preconditions and environment

• Magento version 2.4.6-p4

Steps to reproduce

$this->searchCriteriaBuilder->addFilter('entity_id', [1,2], 'in');
$searchCriteria = $this->searchCriteriaBuilder->create();
$this->productRepository->getList($searchCriteria);

2. $this->productRepository->getById(1);

Expected result

getById method should use cache generated by getList

Actual result

Product with ID 1 is loaded twice. This is because the cache key is generated with storeId = null for getById, but with storeId = 1 (default store) for getList.

(Same thing with get instead of getById)

Additional information

get :

magento2/app/code/Magento/Catalog/Model/ProductRepository.php

Lines 278 to 280 in 488c103

	public function get($sku, $editMode = false, $storeId = null, $forceReload = false)
	{
	$cacheKey = $this->getCacheKey([$editMode, $storeId === null ? $storeId : (int) $storeId]);

getById :

magento2/app/code/Magento/Catalog/Model/ProductRepository.php

Lines 308 to 310 in 488c103

	public function getById($productId, $editMode = false, $storeId = null, $forceReload = false)
	{
	$cacheKey = $this->getCacheKey([$editMode, $storeId]);

getList :

magento2/app/code/Magento/Catalog/Model/ProductRepository.php

Lines 717 to 727 in 488c103

	foreach ($collection->getItems() as $product) {
	$this->cacheProduct(
	$this->getCacheKey(
	[
	false,
	$product->getStoreId()
	]
	),
	$product
	);
	}

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @Nuranto,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the latest development branch i.e. 2.4-develop and we are able to reproduce the issue.

There are 2 cache keys have been generated for 2 calls below:
First Call

$this->searchCriteriaBuilder->addFilter('entity_id', [1], 'in');
$searchCriteria = $this->searchCriteriaBuilder->create();
$this->productRepository->getList($searchCriteria);

Second Call

$this->productRepository->getById(1);

We have made a custom module to reproduce the issue. Please find attached the same for the reference:

Magz.zip

Hence confirming the issue.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11730 is successfully created for this GitHub issue.