Skip to content

[Issue] Correct colspan in visual swatch admin #39360

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #39359: Correct colspan in visual swatch admin


Description (*)

The colspan is incorrect. Probably based on the text.phtml file, but there is only 1 th per store + 4 additional, as you can see in the code.

Manual testing scenarios (*)

Edit a visual swatch and look at the tfoot of the swatches table. The number does not match the number of columns if the number of storeviews is > 1 . For 1 storeview, the number still matches (1 * 2 + 3 = 5 and 1 + 4 = 5), but otherwise it will be too high.

(As far as I can tell, this doesn't have any effect because the number of stores is at least 1 so the colspan will always be high

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Issue: ready for confirmationPriority: P4No current plan to fix. Fixing can be deferred as a logical part of more important work.Reported on 2.4.xIndicates original Magento version for the Issue report.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

Status

Ready for Development

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions