[Issue] Added null check in DataFixtureSetup for the scope

[m2-assistant]

This issue is automatically created based on existing pull request: #39423: Added null check in DataFixtureSetup for the scope

---

Description (*)

The scope defined in a data fixture could be an arbitrary string. If there is no corresponding value in the storage manager null is returned.

In this case null is passed to the scope switcher which leads to a TypeError, because it requires an object of type ScopeInterface.

The TypeError is now prevented by throwing a RuntimeException with a more specific message.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @stollr,

Thanks for the report and collaboration!

We request you please provide us with more details on the fix provided in the PR as below:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Thanks

[stollr]

Sorry for not providing all required information.

Magento's integration test framework offers a way to create data fixtures with the Magento\TestFramework\Fixture\DataFixture attribute. The DataFixture's fourth argument in the constructor is $scope. If a value is passed, that does not exist in the DataFixtureStorageManager it will lead to TypeError in this line.

How to reproduce

Add an integration test to your own test suite that uses a data fixture with an invalid config. For example:

<?php

namespace MyVendor\MyModule\Test\Integration;

use Magento\Catalog\Test\Fixture\Product as ProductFixture;
use Magento\TestFramework\Fixture\DataFixture;
use Magento\TestFramework\Fixture\DbIsolation;
use PHPUnit\Framework\TestCase;

class SynchronizerTest extends TestCase
{
    #[DbIsolation(true)]
    #[DataFixture(
        ProductFixture::class,
        ['sku' => 'test', 'name' => 'Test', 'price' => '7.77'],
        'test',
        'invalid_scope_key' // this line results in an error
    )]
    public function testSynchronize(): void
    { }
}

If you'll run the test now, you'll see that an error appears, because the DataFixtureStorageManager does not have an item with the key invalid_scope_key.