Product List Customer Segment condition works incorrectly and overloads the website

[zhovnirigor]

Preconditions and environment

When there is a customer segment rule with any Product List condition, AND a guest without the quote performs any POST request, the following SQL query is ran in \Magento\CustomerSegment\Model\Segment\Condition\Product\Combine\ListCombine::isSatisfiedBy:
SELECT item.* FROM quote_item item INNER JOIN quote ON item.quote_id = quote.entity_id WHERE ( quote.store_id IN( ? ) ) AND ( quote.is_active = ? )
This is incorrect behavior, and has two undesired consequences:

1. Segment Rule is applied based on all active quote items for this store, not on guest's quote.
2. The SQL request above is executed without index keys applied, and for huge quote_item table this creates a significant MaridDB overload for a significant number of POST requests.

This should never happen for the guests that do not have quotes.

• Magento version 2.4.7-p3

Steps to reproduce

1. Create a new Customer Segment. Set Apply To to Visitors or Visitors and Registered Customers. In conditions, select a single [Products] Product List condition, and select any subcondition for it (for instance, Attribute Set is Shirts).
2. In incognito browser window, navigate to the site frontend. Perform any POST request which does not create quote (for instance, submit Contact Us form).

Expected result

Product List condition is processed correctly - if guest doesn't have quote, \Magento\CustomerSegment\Model\Segment\Condition\Product\Combine\ListCombine::isSatisfiedBy returns value based on the operator only (and not getting to the quote items request)

Actual result

The SQL query above is ran. No indexes are used, which overloads MariaDB, and segment is applied based on someone else's quotes.

Additional information

The following patch solves the problem

customer_segments.patch.zip

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @zhovnirigor. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @zhovnirigor,

Thanks for the report and collaboration!

We have analysed the issue and found that if we have lots of data in the table quote_item then this query may results in slower output. Hence confirming this issue.

I can see you already have patch/fix for this issue, So I suggest you to create a PR. We will be happy to move that PR further.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14174 is successfully created for this GitHub issue.