GroupedProductGQL - When loading the child products the load is one-by-one (N+1 vs 1 load - Performance)

[steven-hoffman-jomashop]

Preconditions and environment

• 2.4.7 (Should be in 2.4.8 as well)
• A grouped product exists with childCount >= 2 (Any number >=5; as a few more to make the N+1 queries more evident is recommended)
• A products GQL call which include the relevant field
  • Should be close to this: { items { id sku ... on GroupedProduct { items { product { id sku } } } } }

Steps to reproduce

• Create the grouped product as above
• Create a GQL query as above
• Enable query logging
• Send the GQL query

Expected result

• 1 query to load the grouped product children
  • (Actually 2 or so; as per normal product collection/list loading)

Actual result

• N queries

Additional information

Issue appears to have been introduced here: ACPT-1181: reset mutable state after request - app/code/Magento/CatalogGraphQl/Model/Resolver/Product.php

• You can observe the change from using the 'singleton' version to using the newly created version

• Changing from the singleton version causes each call to this resolver to load only that one child

  • Where, using the singleton, the deferred nature of the valueFactory with a callback meant that all, (subject to GQL resolution rules), would be set via addProductSku prior to the first one to trigger the callback
  • Then the full list is loaded at once, and each subsequent valueFactory callback to resolve would use the previously loaded data.

• (Also note, cursory review shows other uses of ProductDataProvider without using the Factory)

• Going back to a singleton would resolve the performance issue

• Converting to a 'BatchResolver' would allow the use of the factory and would enable mitigation of the performance issue

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @steven-hoffman-jomashop. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @steven-hoffman-jomashop,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

We have followed this document https://developer.adobe.com/commerce/webapi/graphql/schema/products/interfaces/types/grouped/ for retrieving grouped product information we got response with 1 query for A grouped product exists with childCount >= 5

{
  "data": {
    "products": {
      "items": [
        {
          "uid": "MTE=",
          "name": "Group",
          "sku": "Group",
          "__typename": "GroupedProduct",
          "items": [
            {
              "qty": 0,
              "position": 1,
              "product": {
                "sku": "Simple",
                "name": "Simple",
                "__typename": "SimpleProduct",
                "url_key": "simple"
              }
            },
            {
              "qty": 0,
              "position": 2,
              "product": {
                "sku": "C2",
                "name": "C2",
                "__typename": "SimpleProduct",
                "url_key": "c2"
              }
            },
            {
              "qty": 0,
              "position": 3,
              "product": {
                "sku": "Nadia Elements Shell",
                "name": "Nadia Elements Shell",
                "__typename": "SimpleProduct",
                "url_key": "nadia-elements-shell"
              }
            },
            {
              "qty": 0,
              "position": 4,
              "product": {
                "sku": "Vulcan Weightlifting Tank",
                "name": "Vulcan Weightlifting Tank",
                "__typename": "SimpleProduct",
                "url_key": "vulcan-weightlifting-tank"
              }
            },
            {
              "qty": 0,
              "position": 5,
              "product": {
                "sku": "fasffs",
                "name": "fasffs",
                "__typename": "SimpleProduct",
                "url_key": "fasffs"
              }
            },
            {
              "qty": 0,
              "position": 6,
              "product": {
                "sku": "gdwwge",
                "name": "gdwwge",
                "__typename": "SimpleProduct",
                "url_key": "gdwwge"
              }
            }
          ]
        }
      ]
    }
  }
}

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[steven-hoffman-jomashop]

@engcom-Bravo, The products are expected to load, that works. The issue is that the DB query is N queries where N is the count of children. (Expected would be 1 query; or two as loading a product collection takes two queries)

[engcom-Bravo]

Hi @steven-hoffman-jomashop,

Thanks for your update.

Could you please elaborate about the DB query if possible please provide screencast or screenshots it will help us to proceed further.

Thanks.

[steven-hoffman-jomashop]

@engcom-Bravo,

This is the standard product collection load. (For each product collection loaded, the products and attributes are loaded; two queries).

Here, as noted above, the code is not 'batching' the child products for one load, but instead is making N collection loads. (For 2*N queries, when 2 queries was the previous behavior.)