Skip to content

list function in prepareColumnsLIst in PHP 7 #5842

Closed
@chris-huffman

Description

@chris-huffman

Preconditions

  1. Magento 2.0.7
  2. PHP 7

Steps to reproduce

  1. call prepareColumnsList() in Magento\Framework\DB\Helper line 199.

list($correlationName, $column, $alias) = $columnEntry;

Expected result

  1. In PHP 7, calling list() starts with the left-most parameter (as stated in the php manual)

Actual result

  1. The method still works, but the values for $correlationName and $alias are reversed and this could result in unexpected errors or confusion.

Metadata

Metadata

Assignees

Labels

Event: distributed-cdDistributed Contribution DayIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.1.xThe issue has been reproduced on latest 2.1 releaseReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releasebug report

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions