Fix product collection sort order to use option sort order. #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. Thanks for the suggestion. Fix has been added into the internal repository. Code changes will be available after one of the next code publications to the GitHub from the internal repository. Closing as complete. |
magento-cicd2
pushed a commit
that referenced
this pull request
Jul 11, 2016
[Firedrakes] [Github] Bugfixes.
magento-engcom-team
added a commit
that referenced
this pull request
Nov 16, 2018
- Merge Pull Request magento/graphql-ce#133 from magento/graphql-ce:complexity-limiter - Merged commits: 1. 6a68bd8 2. 660e393 3. 351ae37 4. 9aedd10 5. 88fb398 6. 99b1d1d 7. 335c173 8. ce50f48 9. b1227fc 10. b91f5c8 11. fc80a85 12. 9302a4f 13. 0a4e959 14. e47e861 15. 1847c71 16. 6392294 17. 4328497 18. 889824e
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 16, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you sort a product collection by a 'select' attribute the products are sorted by the attribute option labels. This pull request changes that to sort by the attribute option sort_order field.
Note, a similar patch works on Magento 1.x (using in production, queries are fast and indexed, confirmed with EXPLAIN), but I have not tested this code with Magento 2.