Skip to content

[TASK] Always setSaveRewritesHistory to 1 for API calls so there will… #18408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[TASK] Always setSaveRewritesHistory to 1 for API calls so there will… #18408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions app/code/Magento/CatalogUrlRewrite/Observer/ProductSaveRewritesHistorySetterObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
namespace Magento\CatalogUrlRewrite\Observer;

use Magento\Catalog\Model\Product;
use Magento\Framework\Event\ObserverInterface;
use Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator;

/**
* Class ProductSaveRewritesHistorySetterObserver
*
* @package Magento\CatalogUrlRewrite\Observer
*/
class ProductSaveRewritesHistorySetterObserver implements ObserverInterface
{
/**
* @var \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator
*/
private $productUrlPathGenerator;

/**
* @param ProductUrlPathGenerator $productUrlPathGenerator
*/
public function __construct(ProductUrlPathGenerator $productUrlPathGenerator)
{
$this->productUrlPathGenerator = $productUrlPathGenerator;
}

/**
* Always set save_rewrites_history to 1 for API calls so there will always be created a SEO rewrite for the old url
*
* @param \Magento\Framework\Event\Observer $observer
* @return void
*/
public function execute(\Magento\Framework\Event\Observer $observer)
{
/**
* @var Product $product
*/
$product = $observer->getEvent()->getProduct();
$urlKey = $this->productUrlPathGenerator->getUrlKey($product);
if (null !== $urlKey) {
$product->setSaveRewritesHistory(1);
}
}
}
16 changes: 12 additions & 4 deletions app/code/Magento/CatalogUrlRewrite/Observer/ProductUrlKeyAutogeneratorObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,19 @@

use Magento\Catalog\Model\Product;
use Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator;
use Magento\Framework\Event\Observer;
use Magento\Framework\Event\ObserverInterface;

/**
* Class ProductUrlKeyAutogeneratorObserver
*
* @package Magento\CatalogUrlRewrite\Observer
*/
class ProductUrlKeyAutogeneratorObserver implements ObserverInterface
{
/**
* @var \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator
*/
protected $productUrlPathGenerator;
private $productUrlPathGenerator;

/**
* @param ProductUrlPathGenerator $productUrlPathGenerator
Expand All @@ -26,12 +30,16 @@ public function __construct(ProductUrlPathGenerator $productUrlPathGenerator)
}

/**
* @param \Magento\Framework\Event\Observer $observer
* Generate url_key and set it on the Product
*
* @param \Magento\Framework\Event\Observer $observer
* @return void
*/
public function execute(\Magento\Framework\Event\Observer $observer)
{
/** @var Product $product */
/**
* @var Product $product
*/
$product = $observer->getEvent()->getProduct();
$urlKey = $this->productUrlPathGenerator->getUrlKey($product);
if (null !== $urlKey) {
Expand Down
12 changes: 12 additions & 0 deletions app/code/Magento/CatalogUrlRewrite/etc/webapi_rest/events.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
<event name="catalog_product_save_before">
<observer name="product_save_rewrites_history_setter" instance="Magento\CatalogUrlRewrite\Observer\ProductSaveRewritesHistorySetterObserver"/>
</event>
</config>
12 changes: 12 additions & 0 deletions app/code/Magento/CatalogUrlRewrite/etc/webapi_soap/events.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
<event name="catalog_product_save_before">
<observer name="product_save_rewrites_history_setter" instance="Magento\CatalogUrlRewrite\Observer\ProductSaveRewritesHistorySetterObserver"/>
</event>
</config>