-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Binding to event collapsible scroll #18609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binding to event collapsible scroll #18609
Conversation
|
Hi @danielgheoltan. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@cpartica helped with this one. |
Hi @danielgheoltan! Can you please sign the CLA so we can process this? Thanks!! |
@miguelbalparda I signed the CLA. |
@danielgheoltan no, you didn't sign the CLA. Please refer to the checks block in the end. You could also do that by clicking the link https://cla.dev.magento.com/magento/magento2?pullRequest=18609 |
@danielgheoltan any chance you can sign the CLA so we can process this? Thanks! |
@miguelbalparda I signed again the CLA. I don't know what's wrong with the CLA. |
Hi @miguelbalparda, thank you for the review. |
@danielgheoltan thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @danielgheoltan. Thank you for your contribution. |
Description (*)
The PDP description/reviews accordion in mobile is designed to jump to top of screen when user clicks on accordion anchor to open content (but necessarily to not top of accordion wrapper). This seems to only occur with phones using iOS.
Manual testing scenarios (*)
Open pdp on mobile phone. http://mydomain.coma/impulse-duffle.html
Scroll down so that "More Information" is at the top of the phone screen and click on "More Information" accordion anchor.
Notice that the text is not shown on the screen and you need to scroll up to see it
EXPECTED RESULTS:
The text given when clicking on the "More Information" accordion anchor is able to be seen on the phone screen without having to scroll back up
ACTUAL RESULTS:
The text given when clicking on the "More Information" accordion anchor is unable to be seen on the phone screen and you need to scroll back up.
Contribution checklist (*)