Skip to content

Binding to event collapsible scroll #18609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Binding to event collapsible scroll #18609

merged 2 commits into from
Nov 22, 2018

Conversation

danielgheoltan
Copy link

@danielgheoltan danielgheoltan commented Oct 14, 2018

Description (*)

The PDP description/reviews accordion in mobile is designed to jump to top of screen when user clicks on accordion anchor to open content (but necessarily to not top of accordion wrapper). This seems to only occur with phones using iOS.

Manual testing scenarios (*)

Open pdp on mobile phone. http://mydomain.coma/impulse-duffle.html
Scroll down so that "More Information" is at the top of the phone screen and click on "More Information" accordion anchor.
Notice that the text is not shown on the screen and you need to scroll up to see it

EXPECTED RESULTS:
The text given when clicking on the "More Information" accordion anchor is able to be seen on the phone screen without having to scroll back up

ACTUAL RESULTS:
The text given when clicking on the "More Information" accordion anchor is unable to be seen on the phone screen and you need to scroll back up.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @danielgheoltan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@danielgheoltan
Copy link
Author

@cpartica helped with this one.

@miguelbalparda
Copy link
Contributor

Hi @danielgheoltan! Can you please sign the CLA so we can process this? Thanks!!

@danielgheoltan
Copy link
Author

@miguelbalparda I signed the CLA.

@slavvka
Copy link
Member

slavvka commented Oct 16, 2018

@danielgheoltan no, you didn't sign the CLA. Please refer to the checks block in the end. You could also do that by clicking the link https://cla.dev.magento.com/magento/magento2?pullRequest=18609

@miguelbalparda
Copy link
Contributor

@danielgheoltan any chance you can sign the CLA so we can process this? Thanks!

@danielgheoltan
Copy link
Author

@miguelbalparda I signed again the CLA. I don't know what's wrong with the CLA.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-3510 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@danielgheoltan thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @danielgheoltan. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants