Skip to content

Fixed icon alignment: Frontend Component theme sort by arrow icon vertical alignment issue. #19639 #19640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

suryakant-krish
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Frontend Component theme sort by arrow icon vertical alignment issue. #19639: Frontend Component theme sort by arrow icon vertical alignment issue.

Manual testing scenarios (*)

  1. Go to frontend > choose any category > see on product list page > sort by arrow icon alignment.
    It is little bit down. Find attached screenshot.
    actual-result
    expected-result

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3640 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop December 10, 2018 18:33
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop December 10, 2018 18:33
@magento-engcom-team magento-engcom-team merged commit e567510 into magento:2.3-develop Dec 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants