Skip to content

[Catalog|Eav] Revert change of PR magento/magento2#13302 not included into revert commit #22561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2019
Merged

[Catalog|Eav] Revert change of PR magento/magento2#13302 not included into revert commit #22561

merged 1 commit into from
May 6, 2019

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Apr 30, 2019 •
edited
Loading

Description (*)

This PR provide revert change of PR #13302 not included into revert commit 06019a6

Fixed Issues (if relevant)

Reverted Catalog collection and eav test
not included into 06019a6

Manual testing scenarios (*)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2019

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur
orlangur requested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Den4ik please add more details - which PR are you referring to and how changes can be verified.

@ghost ghost assigned orlangur Apr 30, 2019
@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 30, 2019

@orlangur
ENGCOM-3502: Introduce resource model pool to replace UniversalFactory #13302

@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 30, 2019 •
edited
Loading

and revert commit "MC-15995: Revert change of PR 3766"
06019a6

@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 30, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, here is your Magento instance.
Admin access: https://i-22561-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@orlangur
Copy link
Contributor

@Den4ik please reflect correct PR number in commit message then (preferable form should contain magento/magento2#NUMBER). Please add some insight in that PR why it was reverted and some steps to description of this PR how to test changes.

@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 30, 2019

@orlangur
Original PR #13302
I see that all relations for ResourceModelPoolInterface removed but forgot about product collection
Currently I have receiving "Class Magento\Framework\Model\ResourceModel\ResourceModelPoolInterface does not exist" for setup:di:compile

@ghost ghost assigned sivaschenko Apr 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4872 has been created to process this Pull Request

orlangur
orlangur requested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message and issue summary does not contain appropriate information, @Den4ik please fix.

@Den4ik Den4ik force-pushed the bug/additional-fix-for-revert-pr-3677 branch from b06f74d to 2d3760e Compare April 30, 2019 19:28
@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 30, 2019

@orlangur commit message updated

@Den4ik Den4ik changed the title Additional files for revert PR 3677 [Catalog|Eav] Revert change of PR magento/magento2#13302 not included into revert commit https://github.com/magento/magento2/commit/06019a6215ea31982494708d55745ae0b9622696 Apr 30, 2019
@Den4ik Den4ik changed the title [Catalog|Eav] Revert change of PR magento/magento2#13302 not included into revert commit https://github.com/magento/magento2/commit/06019a6215ea31982494708d55745ae0b9622696 [Catalog|Eav] Revert change of PR magento/magento2#13302 not included into revert commit Apr 30, 2019
@ghost ghost assigned sidolov Apr 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4872 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4872 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 2d3760e into magento:2.3-develop May 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 6, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 6, 2019
@sivaschenko
ENGCOM-4872: Additional files for revert PR 3677 #22561
09af726
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 6, 2019
@Den4ik Den4ik deleted the bug/additional-fix-for-revert-pr-3677 branch May 22, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@sivaschenko sivaschenko sivaschenko approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@orlangur orlangur

@sivaschenko sivaschenko

@sidolov sidolov

Labels
Cleanup Component: Catalog Component: Eav Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Den4ik @magento-engcom-team @orlangur @sivaschenko @sidolov