-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed LayeredNavigation color filter show only loader for out of stock product #24728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed LayeredNavigation color filter show only loader for out of stock product #24728
Conversation
Hi @ravi-chandra3197. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @VladimirZaets, thank you for the review. |
✔️ QA Passed |
…r out of stock product #24728
Hi @ravi-chandra3197, thank you for your contribution! |
Seems like solution isn't fully correct as it prevents rendering product details even if it's not "color swatches". The issue appeared in the color swatches module, so we have to fix the issue in it by adding such change to the following file https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Swatches/view/frontend/templates/product/listing/renderer.phtml. Also all plugins for method |
Just created issue for this improvement #29286 |
Description (*)
Fixed LayeredNavigation color filter show only loader for out of stock product
Fixed Issues (if relevant)
color filter with LayeredNavigation show only loader for out of stock product
Manual testing scenarios (*)
###Actual result (*)

color filter show loader for out of stock product and give console error
"swatch-renderer.js:1264 Uncaught TypeError: $(...).AddFotoramaVideoEvents is not a function"
###Expected result (*)

listing page not showing swatch for out of stock product same as a product detail page
and loader not showing with filter
Questions or comments
Contribution checklist (*)