Skip to content

Fixed LayeredNavigation color filter show only loader for out of stock product #24728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ravi-chandra3197
Copy link
Contributor

Description (*)

Fixed LayeredNavigation color filter show only loader for out of stock product

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
    color filter with LayeredNavigation show only loader for out of stock product

Manual testing scenarios (*)

  1. magento 2.3 with sample data
  2. set configurable product out of stock, make sure child is in stock
  3. Display Out of Stock Products set to Yes
  4. select color witch available in configurable product

###Actual result (*)
color filter show loader for out of stock product and give console error
"swatch-renderer.js:1264 Uncaught TypeError: $(...).AddFotoramaVideoEvents is not a function"
Screenshot from 2019-09-25 19-39-12

###Expected result (*)
listing page not showing swatch for out of stock product same as a product detail page
and loader not showing with filter
Screenshot from 2019-09-25 19-52-24

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2019

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5954 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 28, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 28, 2019
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jul 27, 2020

Hi @ravi-chandra3197,

Seems like solution isn't fully correct as it prevents rendering product details even if it's not "color swatches". The issue appeared in the color swatches module, so we have to fix the issue in it by adding such change to the following file https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Swatches/view/frontend/templates/product/listing/renderer.phtml.

Also all plugins for method getProductDetailsHtml are not executed, as result plugins for this method will not be executed either that might cause issues with customizations, for instance we had it.

@ihor-sviziev
Copy link
Contributor

Just created issue for this improvement #29286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants