Fix translation retrieval

[brosenberger]

Description (*)

Translationstrings are collected in the static content deploy step with configurable regex-patterns (for the js-tranlsations.json-file - all translations available within a js context (js, ko-templates)).

when bundling of js files is enabled, all html-ko templates do get bundled and attribute-quotes do get escaped. this breaks the current js-file retrieval pattern for translation args

Manual testing scenarios (*)

1. add translation for in any language
2. js bundling activated, set locale for the store to where the translation is added
3. static content deploy
4. go to checkout 2. page in luma theme
5. check if Your cart (right summary box headline) is translated

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @brosenberger. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-6319 has been created to process this Pull Request

[engcom-Alfa]

Hi @brosenberger.

Could you provide more details on how to reproduce this issue?
Because with standard translation phrases all work correctly and they are recorded into js-translation.json file.
It would be good if you provided an example.

Thanks!

[brosenberger]

@engcom-Alfa : i have js-bundling enabled for the static content deploy and following bundle.js is generated for the Magento_Checkout/template/summary/cart-itmes.html (part of it:)

</td>\n</tr>\n","Magento_Checkout/template/summary/cart-items.html":"<!--\n/**\n * Copyright \u00a9 Magento, Inc. All rights reserved.\n * See COPYING.txt for license details.\n */\n-->\n<div class=\"block items-in-cart\">\n <div class=\"title\" data-role=\"title\">\n <strong role=\"heading\" aria-level=\"1\">\n <translate args=\"'Your cart'\"/>\n </strong>\n </div>\n <div class=\"content minicart-items\" data-role=\"content\">\n <div class=\"minicart-items-wrapper overflowed\">\n <ol class=\"minicart-items\">\n <each args=\"items()\">\n <li class=\"product-item\">\n <div class=\"product\">\n <each args=\"$parent.elems()\" render=\"\"/>\n </div>\n </li>\n </eac

the original translation regex does not catch

magento2/app/code/Magento/Checkout/view/frontend/web/template/summary/cart-items.html

Line 13 in f6405d5

<translate args="'Item in Cart'" if="getCartLineItemsCount() === 1"/>

(there has been probably a change from <translate args="'Your cart'"/>to a item count specific version, but the pattern would not be applied either as it gets escaped to <translate args=\"'Your cart'\"/> respectivelly <translate args=\"'Item in Cart'\" i...

[engcom-Alfa]

Hi @brosenberger .
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.
Thanks!

[dmytro-ch]

Hello @brosenberger, could you please update your working branch with the latest changes from 2.4-develop and resolve merge conflicts?
Thank you!

[engcom-Echo]

@magento run all tests

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-6319 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @brosenberger, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.