-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add indexer console command output #25638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexer console command output #25638
Conversation
update forked repository 2.3 branch
add additional id column to bin/magento indexer:status command in order to have that information ready
Hi @brosenberger. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
adapt test to contain new id column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small recommendation related to Type Hints.
app/code/Magento/Indexer/Console/Command/IndexerStatusCommand.php
Outdated
Show resolved
Hide resolved
Hi @lbajsarowicz, thank you for the review.
|
@brosenberger thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
@lbajsarowicz Could you review the last commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I meant the argument type declaration.
app/code/Magento/Indexer/Console/Command/IndexerStatusCommand.php
Outdated
Show resolved
Hide resolved
Hi @lbajsarowicz, thank you for the review.
|
Hi @brosenberger, thank you for your contribution! |
add additional id column to bin/magento indexer:status command in order to have that information ready
Description (*)
in order to ease the process of the unregular event an indexer has to be reindexed by a console command on a (e.g. live-)server i want to see which indizes are not in status ready and reindex them with the second command bin/magento indexer:reindex <> which is now available with the status command
Manual testing scenarios (*)
Contribution checklist (*)