-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Resolve Mass Delete Widget should have "Confirmation Modal" #25733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Mass Delete Widget should have "Confirmation Modal" #25733
Conversation
Hi @edenduong. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @edenduong. Thanks for collaboration. Why this test is green if it should already check this case? |
Hi @aleron75, thank you for the review. |
✔️ QA Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edenduong. Thank you for collaboration. I think we should cover it with functional tests (or update an existing one)
@VladimirZaets : Thank you for reviewing. I will update functional test soon. |
@magento run all tests |
@VladimirZaets MFTF test added. Please review. |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
@magento run Functional Tests EE |
Hi @edenduong, thank you for your contribution! |
Description (*)
Mass Delete Widget should have "Confirmation Modal" like that:
We can see it is already in Functional Test (dev/tests/functional/tests/app/Magento/Widget/Test/TestCase/DeleteWidgetEntityTest.php), but it doesn't have the code to do the business.
=> We should open Confirmation Modal when delete widget by mass action.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)