Skip to content

Resolve Mass Delete Widget should have "Confirmation Modal" #25733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

Mass Delete Widget should have "Confirmation Modal" like that:

image

We can see it is already in Functional Test (dev/tests/functional/tests/app/Magento/Widget/Test/TestCase/DeleteWidgetEntityTest.php), but it doesn't have the code to do the business.

image

=> We should open Confirmation Modal when delete widget by mass action.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to backend, create some widget
  2. Select and choose mass action Delete widget.
  3. Check the modal:

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets
Copy link
Contributor

Hi @edenduong. Thanks for collaboration. Why this test is green if it should already check this case?

@ghost ghost assigned aleron75 Dec 3, 2019
@aleron75 aleron75 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6384 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong. Thank you for collaboration. I think we should cover it with functional tests (or update an existing one)

@ghost ghost assigned VladimirZaets Dec 3, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 3, 2019
@edenduong
Copy link
Contributor Author

@VladimirZaets : Thank you for reviewing. I will update functional test soon.

@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Progress: needs update labels Jan 29, 2020
@engcom-Kilo
Copy link
Contributor

@VladimirZaets MFTF test added. Please review.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6384 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@slavvka
Copy link
Member

slavvka commented Mar 15, 2020

@magento run Functional Tests EE

@magento-engcom-team magento-engcom-team merged commit c6672eb into magento:2.4-develop Mar 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 18, 2020

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.