-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Experius 2.3 patch catalog flat #25734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experius 2.3 patch catalog flat #25734
Conversation
Hi @lewisvoncken. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lewisvoncken,
Your changes looks good to me. Could you cover your changes with tests and fix static test failures?
@magento run Integration Tests |
Hi @ihor-sviziev, I'll take care of the test coverage. |
fix static
test coverage
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
Hi @lewisvoncken, thank you for your contribution! |
Description (*)
When the index type product flat is set to 'On Schedule' disabled products were not removed from the table until a full reindex.
Manual testing scenarios (*)
On Schedule
indexer_update_all_views
cron with magerun2 or make sure the cron is runningindexer_update_all_views
cron with magerun2 or make sure the cron is runningQuestions or comments
Contribution checklist (*)