MFTF: Extract Action Groups to separate files - magento/module-reports

[lbajsarowicz]

Description (*)

Extract each Action Group to separate file, to follow MFTF Best Practices.

Fixed Issues (if relevant)

1. Fix/inconsistent test names #22853

Questions or comments

Had to extract the changes per-module. The previous try failed, because of conflicts.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6359 has been created to process this Pull Request

[engcom-Alfa]

QA not applicable

[ihor-sviziev]

@lbajsarowicz
Maybe we can create some static test that will check if action group is one in file?

[lbajsarowicz]

@ihor-sviziev Definitely after cleaning up the mess that we already have - we should have such. This should also check if the filename corresponds with the only test name inside.

[ihor-sviziev]

@lbajsarowicz could you report an issue for that, just in order not to miss it

[lbajsarowicz]

Yes, I'll do it for both magento2 repository and magento-functional-tests-migration

[ihor-sviziev]

Thank you!

…

On Fri, 29 Nov 2019 at 13:40, Lukasz Bajsarowicz ***@***.***> wrote: Yes, I'll do it for both magento2 repository and magento-functional-tests-migration — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25812?email_source=notifications&email_token=AAOJOUKDODHNJQ4HYSOOVOLQWD5UHA5CNFSM4JSWNRX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOU5OY#issuecomment-559763131>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOJOUMGH7IWOONF3IJNUVLQWD5UHANCNFSM4JSWNRXQ> .

[lbajsarowicz]

@VladimirZaets Could you explain why this Pull Request cannot be merged to 2.3? There are no backward incompatible changes.

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.