Skip to content

MFTF: Replace redundant Action Group with proper one - magento/module-page-cache #25817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Remove one redundant Action Group
Replace references to the right one.

@rogyar / @okolesnyk Please keep in mind that the tests there do not test anything!

Fixed Issues (if relevant)

  1. Fix/inconsistent test names #22853

Questions or comments

Had to extract the changes per-module. The previous try failed, because of conflicts.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2019

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lbajsarowicz, could please also copy the annotations/description from the removed clearPageCache action group to ClearPageCacheActionGroup one?

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could please also copy the annotations/description from the removed clearPageCache action group to ClearPageCacheActionGroup one?

Sorry, my mistake. It's already there.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6362 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 29, 2019
@engcom-Alfa engcom-Alfa self-assigned this Nov 29, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@lbajsarowicz
Copy link
Contributor Author

@okolesnyk / @okorshenko / @dmytro-ch / @VladimirZaets

Dear Maintainers, due to your concerns about backward compatibility, I provided the _Deprecated_ActionGroup.xml that provides the deprecated ActionGroups that will be loaded like before, but extra comment was added to notify about depreciation.

Hope that will let you merge that sooner than with 2.4

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:10
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6362 has been created to process this Pull Request

magento-engcom-team pushed a commit that referenced this pull request Dec 20, 2019
@magento-engcom-team magento-engcom-team merged commit 76f310f into magento:2.4-develop Dec 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 20, 2019

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants