-
Notifications
You must be signed in to change notification settings - Fork 9.4k
MFTF: Replace redundant Action Group with proper one - magento/module-page-cache #25817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Replace redundant Action Group with proper one - magento/module-page-cache #25817
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lbajsarowicz, could please also copy the annotations/description
from the removed clearPageCache
action group to ClearPageCacheActionGroup
one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could please also copy the annotations/description from the removed clearPageCache action group to ClearPageCacheActionGroup one?
Sorry, my mistake. It's already there.
Hi @dmytro-ch, thank you for the review.
|
✔️ QA Passed |
@okolesnyk / @okorshenko / @dmytro-ch / @VladimirZaets Dear Maintainers, due to your concerns about backward compatibility, I provided the Hope that will let you merge that sooner than with |
Hi @dmytro-ch, thank you for the review. |
…agento/module-page-cache #25817
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Remove one redundant Action Group
Replace references to the right one.
@rogyar / @okolesnyk Please keep in mind that the tests there do not test anything!
Fixed Issues (if relevant)
Questions or comments
Had to extract the changes per-module. The previous try failed, because of conflicts.
Contribution checklist (*)