Skip to content

Refactor: Remove deprecated methods #26028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

andrewbess
Copy link
Contributor

Description (*)

Code cleanup. Deprecated methods were removed.

  1. Deprecated method "loadConfigFile" has removed from "Magento\Framework\App\DeploymentConfig\Reader"

Fixed Issues (if relevant)

  1. Nope

Manual testing scenarios (*)

  1. Nope

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

- removed deprecated method "loadConfigFile" from "Magento\Framework\App\DeploymentConfig\Reader"
@m2-assistant
Copy link

m2-assistant bot commented Dec 13, 2019

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 13, 2019
@pmclain pmclain self-requested a review December 13, 2019 15:57
@pmclain pmclain self-assigned this Dec 13, 2019
@pmclain
Copy link
Contributor

pmclain commented Dec 13, 2019

@andrewbess Thanks for the PR. I'm getting in touch with the rest of the community engineering team to discuss the general strategy for deprecated code removal.

@magento-engcom-team
Copy link
Contributor

Hi @pmclain, thank you for the review.
ENGCOM-6506 has been created to process this Pull Request

@engcom-Charlie
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@andrewbess andrewbess deleted the code-cleanup branch October 28, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: App Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants