Fixed spelling and adjusted white spaces #26048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

magento-engcom-team merged 6 commits into magento:2.4-develop from pawan:spell-fix

Jan 9, 2020

Member

pawan commented Dec 14, 2019

Description (*)

Corrected spelling and adjust white space to increase readability

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)


          spelling fix and put space

179b854

pawan requested a review from akaplya as a code owner

December 14, 2019 17:32

m2-assistant bot commented Dec 14, 2019

Hi @pawankparmar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz approved these changes

View reviewed changes

Contributor

lbajsarowicz left a comment

Please fix Static tests, then PR will be automatically approved.

ghost assigned lbajsarowicz

ghost added the Progress: ready for testing label

magento-engcom-team added Release Line: 2.4 Component: Catalog labels

Contributor

magento-engcom-team commented Dec 14, 2019

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6474 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

Contributor

magento-engcom-team commented Dec 14, 2019

@pawankparmar thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Member Author

pawan commented Dec 15, 2019 •

edited

Loading

Please fix Static tests, then PR will be automatically approved.

Hello @lbajsarowicz , do I need to phpcs OR phpcbf file ?

Contributor

lbajsarowicz commented Dec 15, 2019

Fix your code to pass static tests

pawankparmar added 2 commits

December 16, 2019 09:39


          fix static test change

3fdf545


          fix static test change with phpcbf

1d63932

engcom-Alfa self-assigned this

ghost added Progress: needs update and removed Progress: ready for testing labels

engcom-Alfa requested a review from lbajsarowicz

December 16, 2019 10:09

Contributor

lbajsarowicz commented Dec 16, 2019

Maybe I was unclear about the expectations.
What you actually have to do is fix these:

lbajsarowicz suggested changes

View reviewed changes

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    */
                   public function setExtensionAttributes(
                       \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes
                   );
-              }
+              }

Contributor

lbajsarowicz Dec 16, 2019

There has to be an empty line at the end of file.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    * @return $this
-                   * @since 101.1.0
+                   * @since  101.1.0
                    */
                   public function setExtensionAttributes(
                       \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes

Contributor

lbajsarowicz Dec 16, 2019

Import the class, make it single line.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    * @return $this
-                   * @since 101.1.0
+                   * @since  101.1.0

Contributor

lbajsarowicz Dec 16, 2019

There should be only one space.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    */
                   public function getExtensionAttributes();
                   /**
                    * Set an extension attributes object.
                    *
-                   * @param \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes
+                   * @param  \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes

Contributor

lbajsarowicz Dec 16, 2019

There should be only one space.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    */
                   public function setRegularPrice($regularPrice);
                   /**
                    * Retrieve existing extension attributes object or create a new one.
                    *
                    * @return \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface|null
-                   * @since 101.1.0
+                   * @since  101.1.0

Contributor

lbajsarowicz Dec 16, 2019

There should be only one space.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    */
                   public function getMaxPrice();
                   /**
                    * Set the max price of the product
                    *
-                   * @param string $maxPrice
+                   * @param  string $maxPrice

Contributor

lbajsarowicz Dec 16, 2019

There should be only one space.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

@@ @@ -42,16 +42,16 @@ public function setFinalPrice($finalPrice); @@
                    * E.g. for product with custom options is price with the most expensive custom option
                    *
                    * @return string
-                   * @since 101.1.0
+                   * @since  101.1.0

Contributor

lbajsarowicz Dec 16, 2019

There should be only one space.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    * @return void
-                   * @since 101.1.0
+                   * @since  101.1.0

Contributor

lbajsarowicz Dec 16, 2019

There should be only one space.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated

                    */
                   public function getFinalPrice();
                   /**
                    * Set the final price: usually it calculated as minimal price of the product
                    * Can be different depends on type of product
                    *
-                   * @param string $finalPrice
+                   * @param  string $finalPrice

Contributor

lbajsarowicz Dec 16, 2019

There should be only one space.

Member Author

pawan Dec 18, 2019

Fixed.

app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php Outdated Show resolved Hide resolved


          Remove extra spaces

b92c9aa

pawan requested a review from lbajsarowicz

December 18, 2019 05:35

Member Author

pawan commented Dec 18, 2019

Maybe I was unclear about the expectations.
What you actually have to do is fix these:

Hello @lbajsarowicz , thank you pointing this.

I have fixed other space issue and new line at the end of file.
Still I couldn't fix "There must be exactly one blank line between lines" issue.

In this pull, I just correct spelling and put space between two words!
I am not getting why static test is failing

I have tried following test for my file:
phpcs --standard=PHPCS /home/comp1/Desktop/FormattedPriceInfoInterface.php
phpcs --standard=Squiz /home/comp1/Desktop/FormattedPriceInfoInterface.php
phpcs --standard=PEAR /home/comp1/Desktop/FormattedPriceInfoInterface.php
phpcs --standard=Zend /home/comp1/Desktop/FormattedPriceInfoInterface.php
phpcs --standard=MySource /home/comp1/Desktop/FormattedPriceInfoInterface.php
phpcs --standard=PSR2 /home/comp1/Desktop/FormattedPriceInfoInterface.php
phpcs --standard=PSR1 /home/comp1/Desktop/FormattedPriceInfoInterface.php

None of the above reported "There must be exactly one blank line between lines" issue

Thank you.

pawankparmar added 2 commits

December 24, 2019 10:44


          Adjust space b/w Short and Long Description

80398d0


          Remove Whitespace

f49510b

Member Author

pawan commented Dec 24, 2019

Please fix Static tests, then PR will be automatically approved.

I have fixed Static tests...

Member Author

pawan commented Jan 1, 2020

@akaplya @lbajsarowicz any updates on PR ? do i need to anything else ?

Member Author

pawan commented Jan 4, 2020

@magento-engcom-team, any updates on PR ? anything remaining from my side ?

lbajsarowicz approved these changes

View reviewed changes

Contributor

lbajsarowicz left a comment

OK

ghost removed the Progress: needs update label

ghost added the Progress: ready for testing label

Contributor

magento-engcom-team commented Jan 8, 2020

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6474 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

ghost added Progress: testing in progress and removed Progress: ready for testing labels

engcom-Alfa added the Auto-Tests: Not Required label

Contributor

engcom-Alfa commented Jan 8, 2020

QA not applicable

ghost added Progress: extended testing and removed Progress: testing in progress labels

engcom-Golf self-assigned this

ghost added Progress: accept and removed Progress: extended testing labels

magento-engcom-team added the Cleanup label

magento-engcom-team pushed a commit that referenced this pull request


          ENGCOM-6474: Fixed spelling and adjusted white spaces #26048

2197c9c

magento-engcom-team merged commit f49510b into magento:2.4-develop

m2-assistant bot commented Jan 9, 2020

Hi @pawankparmar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

pawan deleted the spell-fix branch

February 15, 2020 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Not Required Cleanup Component: Catalog Progress: accept Release Line: 2.4