Skip to content

[Weee] Cover Weee Plugin by Unit Test #26127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

Increase Test Coverage

Cover class:

  • Magento\Weee\Plugin\Catalog\Controller\Adminhtml\Product\Initialization\Helper\ProcessTaxAttribute
  • Magento\Weee\Plugin\Ui\DataProvider\WeeeSettings

Fixed Issues (if relevant)

Manual testing scenarios (*)

  • vendor/bin/phpunit app/code/Magento/Weee/Test/Unit/Plugin/Catalog/Controller/Adminhtml/Product/Initialization/Helper/ProcessTaxAttributeTest.php

  • vendor/bin/phpunit app/code/Magento/Weee/Test/Unit/Plugin/Ui/DataProvider/WeeeSettingsTest.php

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from akaplya as a code owner December 19, 2019 03:27
@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

edenduong and others added 2 commits December 19, 2019 22:23
…nhtml/Product/Initialization/Helper/ProcessTaxAttributeTest.php

Co-Authored-By: Dmytro Cheshun <[email protected]>
…nhtml/Product/Initialization/Helper/ProcessTaxAttributeTest.php

Co-Authored-By: Dmytro Cheshun <[email protected]>
@edenduong
Copy link
Contributor Author

@dmytro-ch: It is ok now. Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6510 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@magento-engcom-team magento-engcom-team merged commit 1c727bb into magento:2.4-develop Dec 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants