-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Code refactor, updated Unit Test with JsonHexTag Serializer #26136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactor, updated Unit Test with JsonHexTag Serializer #26136
Conversation
Hi @srsathish92. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/Checkout/Test/Unit/Block/Cart/ShippingTest.php
Outdated
Show resolved
Hide resolved
app/code/Magento/Checkout/Test/Unit/Block/Cart/ShippingTest.php
Outdated
Show resolved
Hide resolved
Hi @lbajsarowicz, thank you for the review.
|
✔️ QA passed |
@lbajsarowicz can you please add the labels. |
Added |
Hi @srsathish92, thank you for your contribution! |
Description (*)
This PR helps to refactor the code of Block/Cart/Shipping in Checkout Module, utilised JsonHexTag class for replacing PHP json_encode with JsonHexTag option, Also covered the unit test case with JsonHexTag class & data provider.
Path:
app/code/Magento/Checkout/Block/Cart/Shipping.php
Manual testing scenarios (*)
vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Checkout/Test/Unit/Block/Cart/ShippingTest.php
Questions or comments
If any please let me know your feedback
Contribution checklist (*)