Skip to content

Code refactor, updated Unit Test with JsonHexTag Serializer #26136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 24, 2019
Merged

Code refactor, updated Unit Test with JsonHexTag Serializer #26136

merged 4 commits into from
Dec 24, 2019

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Dec 19, 2019

Description (*)

This PR helps to refactor the code of Block/Cart/Shipping in Checkout Module, utilised JsonHexTag class for replacing PHP json_encode with JsonHexTag option, Also covered the unit test case with JsonHexTag class & data provider.

Path: app/code/Magento/Checkout/Block/Cart/Shipping.php

Manual testing scenarios (*)

vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Checkout/Test/Unit/Block/Cart/ShippingTest.php

Questions or comments

If any please let me know your feedback

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2019

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Dec 19, 2019
@ghost ghost assigned lbajsarowicz Dec 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6514 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf engcom-Golf self-assigned this Dec 23, 2019
@engcom-Golf engcom-Golf added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 23, 2019
@srsathish92
Copy link
Contributor Author

@lbajsarowicz can you please add the labels.

@lbajsarowicz
Copy link
Contributor

Added Test coverage

@magento-engcom-team magento-engcom-team merged commit 1e1cbf5 into magento:2.4-develop Dec 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants