Skip to content

[Bundle] Covering the SetAttributeTabBlockObserver for Bundles by Unit Test #26148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2019
Merged

[Bundle] Covering the SetAttributeTabBlockObserver for Bundles by Unit Test #26148

merged 2 commits into from
Dec 24, 2019

Conversation

eduard13
Copy link
Contributor

Description (*)

This PR adds missing unit tests for the following class:

  • \Magento\Bundle\Observer\SetAttributeTabBlockObserver

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 requested a review from akaplya as a code owner December 20, 2019 09:58
@m2-assistant
Copy link

m2-assistant bot commented Dec 20, 2019

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 20, 2019
lbajsarowicz
lbajsarowicz suggested changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use ObjectManager helper ( \Magento\Framework\TestFramework\Unit\Helper\ObjectManager ) and then everything is fine :-)

app/code/Magento/Bundle/Test/Unit/Observer/SetAttributeTabBlockObserverTest.php Outdated
->disableOriginalConstructor()
->getMock();

$this->observer = new SetAttributeTabBlockObserver(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ObjectManager helper for Unit Tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👌

@ghost ghost assigned lbajsarowicz Dec 20, 2019
lbajsarowicz
lbajsarowicz approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for your contribution.

@engcom-Alfa engcom-Alfa self-assigned this Dec 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6511 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 20, 2019
@engcom-Golf engcom-Golf self-assigned this Dec 20, 2019
magento-engcom-team pushed a commit that referenced this pull request Dec 24, 2019
@VladimirZaets
ENGCOM-6511: [Bundle] Covering the SetAttributeTabBlockObserver for B…
5802635 
…undles by Unit Test #26148
@magento-engcom-team magento-engcom-team merged commit f9cf188 into magento:2.4-develop Dec 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Bundle Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eduard13 @magento-engcom-team @engcom-Alfa @lbajsarowicz @dmytro-ch @engcom-Golf