-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Analytics] Code refactor & covered unit test in Analytics/ReportXml/QueryFactory #26761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analytics] Code refactor & covered unit test in Analytics/ReportXml/QueryFactory #26761
Conversation
Hi @srsathish92. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/Analytics/Test/Unit/ReportXml/QueryFactoryTest.php
Outdated
Show resolved
Hide resolved
Functional test failures not related to this PR |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
…cs/ReportXml/QueryFactory #26761
Hi @srsathish92, thank you for your contribution! |
Description (*)
This PR utilise the existing
JSON class
instead of PHPjson_encode
,json_decode
, reused the Query Object create method & covered with unit test..Manual testing scenarios (*)
vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Analytics/Test/Unit/ReportXml/QueryFactoryTest.php
Questions or comments
If any please let me know your feedback's
Contribution checklist (*)