Skip to content

Clean up 'isset' coding style #26772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 22, 2020
Merged

Clean up 'isset' coding style #26772

merged 10 commits into from
Feb 22, 2020

Conversation

GraysonChiang
Copy link
Contributor

Description (*)

Code clean up

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @GraysonChiang. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev self-assigned this Feb 8, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Feb 8, 2020
ihor-sviziev
ihor-sviziev requested changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GraysonChiang,
Could you review my comments and test failures and fix found issues?

lbajsarowicz
lbajsarowicz suggested changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the comment.

Failing tests not related to changes

@ghost ghost assigned lbajsarowicz Feb 8, 2020
@lbajsarowicz
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6833 has been created to process this Pull Request

@ihor-sviziev ihor-sviziev removed their assignment Feb 9, 2020
@engcom-Delta engcom-Delta self-assigned this Feb 10, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf
Copy link
Contributor

Failed functional test not related to the changes in this PR test fails in 2.4-develop with MSI modules.

@slavvka
Copy link
Member

slavvka commented Feb 13, 2020

Looks like code style tests are failing. waiting for builds

@slavvka
Copy link
Member

slavvka commented Feb 13, 2020

@magento run all tests

@engcom-Golf
Copy link
Contributor

I will fix failed tests

slavvka
slavvka reviewed Feb 14, 2020
View reviewed changes
app/code/Magento/Ui/Component/AbstractComponent.php Outdated
@@ -141,8 +142,6 @@ protected function prepareChildComponent(UiComponentInterface $component)

/**
* Produce and return block's html output
*
* @return string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the interface UiComponentInterface and method render this method must return string. I think here we need to return the result instead of changing PHPDocs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@engcom-Golf
Copy link
Contributor

@slavvka done ✔️

magento-engcom-team pushed a commit that referenced this pull request Feb 22, 2020
@slavvka
ENGCOM-6833: Clean up 'isset' coding style #26772
be10913
@magento-engcom-team magento-engcom-team merged commit aa29281 into magento:2.4-develop Feb 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 22, 2020

Hi @GraysonChiang, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka left review comments

@engcom-Golf engcom-Golf engcom-Golf left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@Nazar65 Nazar65 Nazar65 approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@VladimirZaets VladimirZaets

@engcom-Delta engcom-Delta

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Bundle Component: Catalog Component: Checkout Component: Config Component: Customer Component: Deploy Component: Dhl Component: Eav Component: ImportExport Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.