Skip to content

Unit test for Magento\Catalog\Observer\SetSpecialPriceStartDate has added #26842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2020
Merged

Unit test for Magento\Catalog\Observer\SetSpecialPriceStartDate has added #26842

merged 2 commits into from
Feb 28, 2020

Conversation

mmezhensky
Copy link

Description (*)

This PR adds unit test that covers Magento\Catalog\Observer\SetSpecialPriceStartDate

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 12, 2020

Hi @mmezhensky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 12, 2020
@mmezhensky mmezhensky requested a review from rogyar February 13, 2020 07:19
@dmytro-ch dmytro-ch self-assigned this Feb 13, 2020
dmytro-ch
dmytro-ch previously requested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mmezhensky , thank you for your contribution.
Could you please fix minor code review recommendations?
Thank you!

@ghost ghost dismissed dmytro-ch’s stale review February 25, 2020 07:02

Pull Request state was updated. Re-review required.

@engcom-Echo engcom-Echo self-assigned this Feb 25, 2020
@ghost ghost removed the Progress: needs update label Feb 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6984 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Feb 26, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 26, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 28, 2020
@VladimirZaets
ENGCOM-6984: Unit test for Magento\Catalog\Observer\SetSpecialPriceSt…
0053c20 
…artDate has added #26842
@magento-engcom-team magento-engcom-team merged commit df930e8 into magento:2.4-develop Feb 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @mmezhensky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@dmytro-ch dmytro-ch

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmezhensky @magento-engcom-team @engcom-Delta @dmytro-ch @VladimirZaets @engcom-Echo