Skip to content

make store switcher style more resistent #26879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

make store switcher style more resistent #26879

wants to merge 1 commit into from

Conversation

Flyingmana
Copy link
Member

make store switcher more resistent against moving of layout blocks
especially, moving the navigation.sections into the header-wrapper

Description (*)

The issue I encountered was related to the duplicated store switcher block for the mobile navigation, which is part of the navigation.sections.

The styling which is here added for the dropdown of the store switcher for the desktop variant, is currently also applied to the mobile variant when moved into the header-wrapper (to have the category navigation on Desktop between logo and other Header Parts)

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. have a layout xml which moves the navigation.sectionsinto the `header-wrapper``
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="2columns-left" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd" label="Customer My Account (All Pages)" design_abstraction="custom">
    <body>

        <move element="navigation.sections" destination="header-wrapper" after="logo"/>
    </body>
</page>
  1. reduce the Website to "mobile size" and check the store switcher in the mobile navigation

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Flyingmana
make store switcher style more resistent
5945605 
make store switcher more resistent against moving of layout blocks
especially, moving the navigation.section into the header-wrapper
@m2-assistant
Copy link

m2-assistant bot commented Feb 14, 2020

Hi @Flyingmana. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ptylek
Copy link
Contributor

ptylek commented Mar 2, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-26879.instances.magento-community.engineering/admin_ae96
Login: 68996f57 Password: ab5879cb3fc9
Instance will be terminated in up to 3 hours.

@ghost ghost assigned ptylek Mar 2, 2020
@ptylek ptylek added Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Progress: needs update labels Mar 2, 2020
ptylek
ptylek previously approved these changes Mar 7, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7061 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Flyingmana thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Mar 10, 2020
engcom-Alfa
engcom-Alfa requested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Flyingmana

During testing, we faced the issue.

Problem: The switch sign is in the wrong position

Manual testing scenario:

  1. have a layout XML which moves the navigation.sectionsinto the header-wrapper;

     <move element="navigation.sections" destination="header-wrapper" after="logo"/>

  2. reduce the Website to "mobile size" and check the store switcher in the mobile navigation;

Actual Result:

Without fix: ❌
after3

With fix: ✔️
after1

  1. Back to the desktop view and click on the switcher button

Actual Result:
❌ The switch sign has incorrect position
after2

@Flyingmana Could you take a look?

Thanks!

@ghost ghost dismissed ptylek’s stale review March 10, 2020 15:00

Pull Request state was updated. Re-review required.

@ptylek
Copy link
Contributor

ptylek commented Mar 25, 2020

Hi @Flyingmana, I close this PR due to inactivity. If you want to continue your work, simply reopen this PR. Thanks!

@ptylek ptylek closed this Mar 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 25, 2020

Hi @Flyingmana, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@vasilii-b
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b, here is your Magento instance.
Admin access: https://i-26879-2-4-develop.instances.magento-community.engineering/admin_7dc8
Login: af567407 Password: 1a9d0b96a1a1
Instance will be terminated in up to 3 hours.

@vasilii-b vasilii-b mentioned this pull request Mar 30, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@ptylek ptylek ptylek left review comments

Assignees

@ptylek ptylek

@engcom-Alfa engcom-Alfa

Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: needs update Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Flyingmana @ptylek @magento-engcom-team @vasilii-b @engcom-Alfa