Skip to content

fix for the issue #26135 #27050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix for the issue #26135 #27050

wants to merge 3 commits into from

Conversation

divyajyothi5321
Copy link
Contributor

@divyajyothi5321 divyajyothi5321 commented Feb 27, 2020 •
edited by ihor-sviziev
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Sticky header for navigation in mobile, desktop #26135 : Sticky header for navigation in mobile, desktop

Manual testing scenarios (*)

  1. Go to any page in magento instance
  2. Scroll the page to the footer
  3. you can observe that the header is not sticky for both mobile and desktop.
  4. With this fix the user is abled to access the header links directly from the footer section.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@divyajyothi5321 divyajyothi5321 self-assigned this Feb 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 27, 2020

Hi @divyajyothi5321. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost unassigned divyajyothi5321 Feb 27, 2020
@ghost
Copy link

ghost commented Feb 27, 2020

@divyajyothi5321 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 6, 2020 •
edited
Loading

Seem your PR already duplicated with PR #26447
But this PR seem cleaner than the PR 26447

@ghost ghost added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels May 21, 2020
@mrtuvn
Copy link
Contributor

mrtuvn commented Jun 14, 2020

@divyajyothi5321 Can you update file by move .lib-sticky-nav() to top right before background-color ?

@mrtuvn mrtuvn mentioned this pull request Jun 22, 2020
Closed
4 tasks
@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 2, 2020

@magento run all tests

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 21, 2021
@magento-engcom-team
Copy link
Contributor

Hi @bgorski, thank you for the review.
ENGCOM-9078 has been created to process this Pull Request
✳️ @bgorski, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@bgorski bgorski self-requested a review May 9, 2021 15:30
@bgorski
Copy link
Contributor

bgorski commented May 9, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor

mrtuvn commented May 10, 2021 •
edited
Loading

i have also created PR for this issue but consideration duplicate with this one (since owner inactive after 1 year). Created my own with some enhancements cleaner solution
See this #28840

@bgorski
Copy link
Contributor

bgorski commented Jul 30, 2021

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@bgorski
Copy link
Contributor

bgorski commented Jul 30, 2021 •
edited
Loading

@divyajyothi5321 thank you for the contribution! The fix is extended in #28840 so I'm putting this one on hold since it's the extension that will get merged but it's great that you got the ball rolling with your awesome contribution, much appreciated!

@bgorski
Copy link
Contributor

bgorski commented Nov 23, 2021

For the reason described above and because #28840 got accepted, this PR can now be closed.

@bgorski bgorski closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanthy-i95dev kanthy-i95dev Awaiting requested review from kanthy-i95dev

@bgorski bgorski Awaiting requested review from bgorski

Assignees

@bgorski bgorski

Labels
Area: Design/Frontend Area: Frontend Area: Lib/Frontend Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sticky header for navigation in mobile, desktop
4 participants
@divyajyothi5321 @mrtuvn @magento-engcom-team @bgorski