Adding failure callback to ui file uploader

[bartoszkubicki]

Description (*)

Magento_Ui file uploader works fine. However, recently when I have used it for custom file upload, and when I had error while uploading file there was no info what happened. Uploader just stopped uploading. After debugging it turned out it was 413 from nginx, and next steps were clear (bumping post, upload and client body size). I think if we have an error we should get info in dev tools console.

Magento_Downloadable file uploader in adminhtml is heavily based on this uploader, so whole thing can be investigated and tested while creating downloadable product.
By the way, I had refactored formatting a little bit.

Manual testing scenarios (*)

1. Open downloadable product form
2. Try to upload huge file exceeding nginx and php limitations (especially client_max_body_size)
3. There is no info, uploader just stops working.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Adding failure callback to ui file uploader #29557: Adding failure callback to ui file uploader

[m2-assistant]

Hi @bartoszkubicki. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lenaorobei]

Hi @bartoszkubicki!
Could you please address build failures.

[bartoszkubicki]

@lenaorobei I have fixed some issue, but now I am stuck. Unit tests are marked as failed, but there is no info what exactly failed even if I visit allure report (and I am writing js not php!).

Functional tests failed because of strange looking communicate - something about browser and selenium - but it doesn't seem to be connected to code changes.

Static tests are failed because of copy-paste in some module I didn't touched. What are we supposed to do with this one?

[lenaorobei]

@bartoszkubicki sorry for the late response. I'm going to update your branch to see new build results. Most likely static failures are related to the es6.

[lenaorobei]

@magento run all tests

[lenaorobei]

@magento run Static Tests

[lenaorobei]

Here is the build console log:

Error Message
Parsing error: The keyword 'let' is reserved
Stacktrace
line 78, col 13, Error - Parsing error: The keyword 'let' is reserved

Please avoid the use of ES6 syntax. Thank you.

[bartoszkubicki]

@lenaorobei Is there any reason why anyone should not use es6? Why there is such a statement in static test?

[lenaorobei]

I think @DrewML is the best person to answer this question.

[sidolov]

@magento create issue

[lenaorobei]

Please fins the requested info here https://devdocs.magento.com/guides/v2.4/coding-standards/technical-guidelines.html?itm_source=devdocs&itm_medium=search_page&itm_campaign=federated_search&itm_term=ECMAScript#10-javascript-js-application

[bartoszkubicki]

@lenaorobei I was curious why such a standard is kept. ECMA 6 seems to be quite supported in all main browsers.

[lenaorobei]

@bartoszkubicki historically this decision is was made to keep IE compatibility. Now it requires revision and reconsideration, but that's the rule for now.

[bartoszkubicki]

@lenaorobei Didn't know that we are going to deal with such a archeology ;)

Code corrected, hope this time all checks will pass.

[lenaorobei]

@magento run all tests

[lenaorobei]

@bartoszkubicki this change caused static build failures https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27092/07579529c64ff7894d0e64a36f65607d/Statics/allure-report-b2b/index.html#suites/0441d6d921f4f55895c022b4645f9e29

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8302 has been created to process this Pull Request

[bartoszkubicki]

@gabrieldagama you were faster :) I was going to look at that this weeekend. So everything is ready?

[engcom-Hotel]

@magento run all tests

[engcom-Delta]

✔️ QA passed
Result according Manual testing scenarios:
❌ Before:

✔️ After:
Additional information about error in dev console

[engcom-Delta]

Note: Functional Tests B2B , Functional Tests CE and Functional Tests EE are failed

[gabrieldagama]

The failing tests are not related to this PR.

[engcom-Delta]

Note: Automation tests are passed

[m2-assistant]

Hi @bartoszkubicki, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[bartoszkubicki]

@lenaorobei Please back-port it to magento 2.3