Skip to content

Cleanup ObjectManager usage - Magento_Translation #27215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2020
Merged

Cleanup ObjectManager usage - Magento_Translation #27215

merged 2 commits into from
Mar 19, 2020

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Mar 9, 2020 •
edited
Loading

Description (*)

This PR cleanups ObjectManager usage in Magento_Translation, by removing object manager instantiation from non-api classes

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 9, 2020

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Mar 10, 2020
@Bartlomiejsz Bartlomiejsz force-pushed the feature/objectmanager_cleanup_translation branch from ccea83d to 9ad08cb Compare March 10, 2020 09:14
lbajsarowicz
lbajsarowicz approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion that's another well done job!

@ghost ghost assigned lbajsarowicz Mar 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7098 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7098 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Mar 17, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 17, 2020
@engcom-Charlie
Copy link
Contributor

Failed functional tests not related to the changes in this PR.

magento-engcom-team pushed a commit that referenced this pull request Mar 19, 2020
@slavvka
ENGCOM-7098: Cleanup ObjectManager usage - Magento_Translation #27215
c4d9c41
@magento-engcom-team magento-engcom-team merged commit 9e28476 into magento:2.4-develop Mar 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/objectmanager_cleanup_translation branch June 23, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: Translation Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bartlomiejsz @magento-engcom-team @engcom-Delta @engcom-Charlie @lbajsarowicz @dmytro-ch