Skip to content

Fix An error occurred during delete folder from a media gallery. #27652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Fix An error occurred during delete folder from a media gallery. #27652

merged 1 commit into from
Apr 10, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Apr 8, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

magento/adobe-stock-integration#1144 An error occurred during delete folder from a media gallery.

Manual testing scenarios (*)

Go to the Catalog -> Categories
Select the default one
Press Content -> Select from Gallery
At the open media, gallery menu try to delete a folder

Expected result (*)

A folder can be deleted and page is unblocked

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Nazar65
Copy link
Member Author

Nazar65 commented Apr 8, 2020

This functionality already covered by MFTF tests in app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryCreateDeleteFolderTest.xml in adobe-stock-integration repository

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7294 has been created to process this Pull Request

@VladimirZaets VladimirZaets added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 9, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 9, 2020
@magento-engcom-team magento-engcom-team merged commit e17c651 into magento:2.4-develop Apr 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants