Backend: focus search field when pressing forwardslash - '/'

[vovayatsyuk]

Description

This PR adds a keydown event listener in magento backend to activate global search form if forward slash was pressed.

No need to grab the mouse!

Manual testing scenarios (*)

1. Login to backend
2. Press '/' on the keyboard.
3. Start typing a query.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Backend: focus search field when pressing forwardslash - '/' #29551: Backend: focus search field when pressing forwardslash - '/'

[m2-assistant]

Hi @vovayatsyuk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sidolov]

@magento create issue

[ihorvansach]

@magento run all tests

[ihorvansach]

@magento run Functional Tests B2B

[ihorvansach]

Hello @vovayatsyuk, thank you for your contribution. Can you please add a few improvements to the pull request?

1. Define key code 191 in the Magento_Ui/js/lib/key-codes (https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Ui/view/base/web/js/lib/key-codes.js), here is an example of key-codes use https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Ui/view/base/web/js/grid/columns/image-preview.js

2. Better to rename "e" variable into "event"

3. Could you please also add "multiselect" to the inputs array

4. Cover this case with MFTF tests (https://devdocs.magento.com/mftf/docs/introduction.html)

5. Don't forget to sign the Adobe CLA agreement.

[ihor-sviziev]

@vovayatsyuk could you update your PR with requested changes in #27674 (comment) ?

[vovayatsyuk]

Define key code 191

Done.

Rename "e" variable into "event"

Done.

Add "multiselect" to the inputs array

Multiselect is a 'select' with multiple attribute, so it's already in the list.

Cover this case with MFTF tests

I'll try to write the tests in a few days.

Sign the Adobe CLA agreement.

Should be ok.

[ihor-sviziev]

@magento run all tests

[engcom-Charlie]

@vovayatsyuk can you please cover your changes by mftf test?
Thank you.

[vovayatsyuk]

Will do today.

[ihor-sviziev]

Thank you for your fixes! Let's start the tests

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests EE, Integration Tests

[ihor-sviziev]

@magento run Functional Tests EE

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes form this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8393 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Login to backend
2. Press '/' on the keyboard.
3. Start typing a query.

After: ✔️ the search box focuses when clicking on the slash - '/'

[m2-assistant]

Hi @vovayatsyuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.