[MFTF] Cancel created orders after checks on frontend #27698

elevinskii · 2020-04-10T16:41:28Z

Description

According to the isolation guidelines of Magento Functional Test Framework, all data created during tests have to be deleted. As we can't delete created orders - there's no way to delete an order neither via backend or webapi - I suppose it'd be an good idea to cancel them.

https://devdocs.magento.com/mftf/docs/guides/test-isolation.html

Updated CheckCheckoutSuccessPageAsRegisterCustomerTest and CheckCheckoutSuccessPageAsGuestTest after blocks, to cancel all orders which have been created in these tests.

New Action Groups

AdminGridBulkActionGroup - massive action for all rows on Admin Grid page
AdminGridColumnShowActionGroup - shows new column on Admin Grid page

Questions or comments

I spent so much time, trying to cancel orders by ids via webapi - but still don't know how to do that in MFTF. If someone has any thoughts or ideas - they'd be appreciated.

Resolved issues:

resolves [Issue] [MFTF] Cancel created orders after checks on frontend #28324: [MFTF] Cancel created orders after checks on frontend

m2-assistant · 2020-04-10T16:41:30Z

Hi @elevinskii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz

Could you - by the way - extract the Tests to separate files? (There are 2 tests in the same file)

--- EDIT ---
I see that you used outdated 2.4-develop, that's why you have 2 tests in same file. Now these tests were isolated.

lbajsarowicz · 2020-04-10T18:35:39Z

app/code/Magento/Checkout/Test/Mftf/Test/CheckCheckoutSuccessPageTest.xml

+            <!--Cancel orders-->
+            <actionGroup ref="AdminLoginActionGroup" stepKey="adminLogin"/>
+            <actionGroup ref="AdminOrdersGridClearFiltersActionGroup" stepKey="goToOrdersPage"/>
+            <waitForLoadingMaskToDisappear stepKey="waitAfterClearFilters"/>


If there's no such action - you can add it to AdminOrdersGridClearFiltersActionGroup

That's done - I've added wait action in the end of AdminOrdersGridClearFiltersActionGroup and did small refactoring for tests where this action group is used.

# Conflicts: # app/code/Magento/Checkout/Test/Mftf/Test/CheckCheckoutSuccessPageTest/CheckCheckoutSuccessPageAsRegisterCustomerTest.xml

elevinskii · 2020-04-11T11:38:27Z

I see that you used outdated 2.4-develop, that's why you have 2 tests in same file. Now these tests were isolated.

Sorry, overlooked that. Now the branch is updated.

lbajsarowicz

✔️ Thank you for your contribution

lbajsarowicz · 2020-04-13T09:47:09Z

...Checkout/Test/Mftf/Test/CheckCheckoutSuccessPageTest/CheckCheckoutSuccessPageAsGuestTest.xml

+            <!--Cancel orders-->
+            <actionGroup ref="AdminLoginActionGroup" stepKey="adminLogin"/>
+            <actionGroup ref="AdminOrdersGridClearFiltersActionGroup" stepKey="goToOrdersPage"/>
+            <actionGroup ref="AdminGridColumnShowActionGroup" stepKey="showCustomerEmailColumn">
+                <argument name="columnLabel" value="Customer Email"/>
+            </actionGroup>
+            <actionGroup ref="AdminGridFilterFillInputFieldActionGroup" stepKey="filterOrdersByCustomerEmail">
+                <argument name="filterInputName" value="customer_email"/>
+                <argument name="filterValue" value="{{CustomerEntityOne.email}}"/>
+            </actionGroup>
+            <actionGroup ref="AdminGridFilterApplyActionGroup" stepKey="applyFilters"/>
+            <actionGroup ref="AdminGridBulkActionGroup" stepKey="cancelOrders">
+                <argument name="actionLabel" value="Cancel"/>
+            </actionGroup>


Awesome! Perfect test example ❗

magento-engcom-team · 2020-04-13T09:49:58Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7334 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

slavvka · 2020-05-21T20:58:52Z

@magento run all tests

… mftf-checkout-cancel-orders

engcom-Echo · 2020-07-01T12:11:47Z

@magento run all tests

… mftf-checkout-cancel-orders � Conflicts: � app/code/Magento/Sales/Test/Mftf/Test/AdminMassOrdersCancelCompleteAndClosedTest.xml � app/code/Magento/Sales/Test/Mftf/Test/AdminMassOrdersCancelProcessingAndClosedTest.xml � app/code/Magento/Sales/Test/Mftf/Test/AdminMassOrdersHoldOnCompleteTest.xml � app/code/Magento/Sales/Test/Mftf/Test/AdminMassOrdersHoldOnPendingAndProcessingTest.xml � app/code/Magento/Sales/Test/Mftf/Test/AdminMassOrdersReleasePendingOrderTest.xml � app/code/Magento/Sales/Test/Mftf/Test/AdminMassOrdersUpdateCancelPendingOrderTest.xml � app/code/Magento/Sales/Test/Mftf/Test/AdminOrdersReleaseInUnholdStatusTest.xml

engcom-Echo · 2020-08-10T11:34:31Z

@magento run all tests

sidolov · 2020-08-26T17:28:20Z

@magento run all tests

sidolov · 2020-08-26T20:50:50Z

@elevinskii please, take a look at failed test

engcom-Echo · 2020-09-01T09:34:43Z

Hi @elevinskii. Please, take a look at a failed tests. Can you fix them?

gabrieldagama · 2020-09-07T10:50:43Z

The risk was set to low due to: Changes on this PR don't affect the platform, just the test suite.

lbajsarowicz

✔️ Looks correct for me.

magento-engcom-team · 2020-09-14T14:10:37Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7334 has been created to process this Pull Request

engcom-Alfa · 2020-09-16T13:33:48Z

QA not applicable

…7698

m2-assistant · 2020-09-18T14:28:37Z

Hi @elevinskii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

elevinskii added 6 commits April 7, 2020 10:03

Created action group for cancel created orders

2b86774

Moved going to order page and clearing the filters outside action group

83a4f09

Created new action group to show new column in admin grid

c66d517

Created action group for massive actions in order admin grid

24f9954

Moved bulk action group to Ui module to use in any admin grid

fd3e813

Cancel created orders after CheckCheckoutSuccessPageAsGuestTest

939ced0

ghost added the Progress: pending review label Apr 10, 2020

magento-engcom-team added Component: Checkout Component: Ui Release Line: 2.4 labels Apr 10, 2020

lbajsarowicz suggested changes Apr 10, 2020

View reviewed changes

ghost assigned lbajsarowicz Apr 10, 2020

ghost added Progress: needs update and removed Progress: pending review labels Apr 10, 2020

elevinskii added 3 commits April 11, 2020 12:40

Merge branch '2.4-develop' into mftf-checkout-cancel-orders

59c16ea

# Conflicts: # app/code/Magento/Checkout/Test/Mftf/Test/CheckCheckoutSuccessPageTest/CheckCheckoutSuccessPageAsRegisterCustomerTest.xml

Updated CheckCheckoutSuccessPageAsGuestTest after update branch

756f2dc

Added wait action in the end of AdminOrdersGridClearFiltersActionGroup

d63b5d8

elevinskii requested a review from lbajsarowicz April 11, 2020 11:49

ghost added Progress: pending review and removed Progress: needs update labels Apr 12, 2020

lbajsarowicz previously approved these changes Apr 13, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: pending review labels Apr 13, 2020

magento-engcom-team added Component: Backend Component: CatalogInventory Component: Sales labels Apr 13, 2020

engcom-Alfa self-assigned this Apr 16, 2020

Merge branch '2.4-develop' of http://github.com/magento/magento2 into…

14ed4b7

… mftf-checkout-cancel-orders

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 14, 2020

sidolov removed this from the 2.4.1 milestone Aug 20, 2020

Merge branch '2.4-develop' into mftf-checkout-cancel-orders

da7af27

gabrieldagama added the Risk: low label Sep 7, 2020

engcom-Echo requested review from slavvka and lbajsarowicz September 10, 2020 10:34

lbajsarowicz approved these changes Sep 14, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Sep 14, 2020

ghost added Progress: testing in progress Progress: extended testing Progress: accept and removed Progress: ready for testing Progress: testing in progress Progress: extended testing labels Sep 16, 2020

magento-engcom-team pushed a commit that referenced this pull request Sep 18, 2020

ENGCOM-7334: [MFTF] Cancel created orders after checks on frontend #2…

0e90a71

…7698

magento-engcom-team merged commit fe23ea3 into magento:2.4-develop Sep 18, 2020

[MFTF] Cancel created orders after checks on frontend #27698

[MFTF] Cancel created orders after checks on frontend #27698

Uh oh!

Conversation

elevinskii commented Apr 10, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

New Action Groups

Questions or comments

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 10, 2020

Uh oh!

lbajsarowicz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz Apr 10, 2020

Choose a reason for hiding this comment

Uh oh!

elevinskii Apr 11, 2020

Choose a reason for hiding this comment

Uh oh!

elevinskii commented Apr 11, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz Apr 13, 2020

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Apr 13, 2020

Uh oh!

slavvka commented May 21, 2020

Uh oh!

engcom-Echo commented Jul 1, 2020

Uh oh!

engcom-Echo commented Aug 10, 2020

Uh oh!

sidolov commented Aug 26, 2020

Uh oh!

sidolov commented Aug 26, 2020

Uh oh!

engcom-Echo commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabrieldagama commented Sep 7, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Sep 14, 2020

Uh oh!

engcom-Alfa commented Sep 16, 2020

Uh oh!

m2-assistant bot commented Sep 18, 2020

Uh oh!

Uh oh!

elevinskii commented Apr 10, 2020 •

edited by ghost

Loading

lbajsarowicz left a comment •

edited

Loading

engcom-Echo commented Sep 1, 2020 •

edited

Loading