\Magento\Framework\Filesystem\Io\File::read() should be able to accept resource in second argument

[bnymn]

\Magento\Framework\Filesystem\Io\File::read() method is not compatible with the IoInterface. This PR aims to make it compatible.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. \Magento\Framework\Filesystem\Io\File::read() method is not compatible with \Magento\Framework\Filesystem\Io\IoInterface::read() #27866: \Magento\Framework\Filesystem\Io\File::read() method is not compatible with \Magento\Framework\Filesystem\Io\IoInterface::read()

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @bnymn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lenaorobei]

Please sign CLA and address test failures.

[engcom-Charlie]

Hi @bnymn, please sign CLA and look through failed tests. Otherwise, we can't proceed with your PR.

[engcom-Charlie]

@magento run all tests

[lenaorobei]

@magento run all tests

[lenaorobei]

@magento run Static Tests

[engcom-Charlie]

Hi, @bnymn can you please fix static tests?
Thank you.

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-8127 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
Result:
Code snippet for testing:

$file = ObjectManager::getInstance()->get(File::class);
        if (!is_dir('var/tmp_1')) {
            // dir doesn't exist, make it
            mkdir('var/tmp_1');
        }
        file_put_contents('var/tmp_1/sample_file', 'Some test file');
        $targetHandle = fopen('var/tmp_1/' . rand(), 'w');
        $file->cd('var/tmp_1');
        $result = $file->read('sample_file', $targetHandle);
        $output->writeln($result);

Before:
❌ $result is null

After:
✔️ File content is copied to the target path

✔️ File is copied to the target file when second argument is string only: `$result = $file->read('sample_file', 'test');

[engcom-Delta]

Note: Automation tests are passed

[m2-assistant]

Hi @bnymn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.