magento/magento2#: Remove a redundant getMappedNums from a loop

[atwixfirster]

Description (*)

Removes a redundant getMappedNums from a loop.

Before changes:

After fix:

Related Pull Requests

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] magento/magento2#: Remove a redundant getMappedNums from a loop #30031: magento/magento2#: Remove a redundant getMappedNums from a loop

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[dmytro-ch]

Hello @atwixfirster, thank you for the suggested improvement :)

Please note, due to Magento Definition of Done the changes must be covered by tests. Could you please cover your fix by the appropriate unit test?

Thank you!

[atwixfirster]

Please note, due to Magento Definition of Done the changes must be covered by tests. Could you please cover your fix by the appropriate unit test?

done

Thank you, @dmytro-ch

[dmytro-ch]

@atwixfirster thank you for the updates!
Could you please just apply the following minor change in order to make sure the test is compatible with PHPUnit 8?

Thank you!

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-7528 has been created to process this Pull Request

[engcom-Echo]

✔️ QA passed

"$ this-> enumDataMapper-> getMappedEnums ($ enumName);" it is possible to take out for "foreach" it will not influence logic but will reduce quantity of uses.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run all tests

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-7528 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

Manual Testing scenario

1. Creare a Customer on Storefront, with the checkbox Subscribed fro Newsletter checked
2. Perform a grphql query

query{
  customer{
    firstname
    lastname
    email
    is_subscribed
    created_at
    prefix
    wishlists{
      id
    }
  }
}

3. See the response data

AR: The response contains all the correct information about the Customer, for example

{
  "data": {
    "customer": {
      "firstname": "Alan",
      "lastname": "Smithee",
      "email": "[email protected]",
      "is_subscribed": true,
      "created_at": "2020-09-25 13:34:27",
      "prefix": null,
      "wishlists": [
        {
          "id": "1"
        }
      ]
    }
  }
}

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.