-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed Issue 12225: Tier pricing tax shows only including tax #27953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issue 12225: Tier pricing tax shows only including tax #27953
Conversation
Hi @jiten-patel. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php
Outdated
Show resolved
Hide resolved
app/code/Magento/ConfigurableProduct/view/base/templates/product/price/tier_price.phtml
Outdated
Show resolved
Hide resolved
Hi @jiten-patel, can you please look at requested changes |
Hi @jiten-patel can you please take a look at failed tests? |
@jiten-patel I'll try to continue with your PR. |
@magento run all tests |
# Conflicts: # app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php
@engcom-Charlie can you update this branch with the latest mainline and solve conflicts? |
@magento run all tests |
Hi @sidolov, thank you for the review.
|
Pull Request state was updated. Re-review required.
@magento run all tests |
Hi @gabrieldagama, thank you for the review.
|
✔️ QA Passed Preconditions: Configurable product with tier pricing Manual testing scenario:
Before: ✖️ The tier price only shows the including tax After: ✔️ The tier price shows the excluding including tax Configurable product: Simple product: Also, was tested - including tax, excluding tax on different types of product and everything work as expected. |
@magento run all tests |
Hi @jiten-patel, thank you for your contribution! |
Description (*)
Related Pull Requests
Steps to reproduce (*)
Go to Sales > Tax >Price display settings.
Configure to show the including and excluding tax price.
Go to a configurable product on the frontend with tier pricing.
You will see tier price including tax.
There is no way to change that to excluding price.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)