Skip to content

Fixed Issue 12225: Tier pricing tax shows only including tax #27953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 24, 2020
Merged

Fixed Issue 12225: Tier pricing tax shows only including tax #27953

merged 13 commits into from
Sep 24, 2020

Conversation

jiten-patel
Copy link
Contributor

Description (*)

Related Pull Requests

Steps to reproduce (*)
Go to Sales > Tax >Price display settings.
Configure to show the including and excluding tax price.
Go to a configurable product on the frontend with tier pricing.
You will see tier price including tax.
There is no way to change that to excluding price.

Fixed Issues (if relevant)

  1. Tier pricing tax shows only including tax #12225: Tier pricing tax shows only including tax

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2020

Hi @jiten-patel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 17, 2020
@engcom-Charlie
Copy link
Contributor

Hi @jiten-patel, can you please look at requested changes
#27953 (comment)
#27953 (comment)
#27953 (comment)
and also check failed tests?

@engcom-Charlie
Copy link
Contributor

Hi @jiten-patel can you please take a look at failed tests?
Looks like after your changes product's options isn't available on configurable PDP.
Thank you.

@engcom-Charlie
Copy link
Contributor

@jiten-patel I'll try to continue with your PR.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

# Conflicts:
#	app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php
@gabrieldagama
Copy link
Contributor

@engcom-Charlie can you update this branch with the latest mainline and solve conflicts?

@engcom-Charlie
Copy link
Contributor

@magento run all tests

sidolov
sidolov previously approved these changes Sep 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8202 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost ghost dismissed gabrieldagama’s stale review September 18, 2020 07:15

Pull Request state was updated. Re-review required.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8202 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

Configurable product with tier pricing

Manual testing scenario:

  1. Go to Admin -> Sales -> Tax -> Price display settings;
  2. Configure to show the including and excluding tax price;
  3. Go to a configurable product on the frontend with tier pricing.

Before: ✖️ The tier price only shows the including tax

2020-09-23_09-20

After: ✔️ The tier price shows the excluding including tax

Configurable product:

2020-09-22_15-13

Simple product:

2020-09-22_15-00

Also, was tested - including tax, excluding tax on different types of product and everything work as expected.

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 23, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 23, 2020
@magento-engcom-team magento-engcom-team merged commit 9861d3e into magento:2.4-develop Sep 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 24, 2020

Hi @jiten-patel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: ConfigurableProduct Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants