#27962 Migrate Plugin out of Framework (to Theme module)

[lbajsarowicz]

Description (*)

During my recent changes related to Controllers decomposition, I renamed the existing plugin. Some random Magento Architect says that it was never allowed to add Plugin to \Magento\Framework namespace and it was never allowed:

I had no idea about that (is there information missing in DevDocs / coding standards / static checks?). So I'm moving plugin out of \Magento\Framework area, as it's against Magento Best Practices.

(If it was never allowed, why it's there since 2016?)

magento2/lib/internal/Magento/Framework/App/Action/Plugin/Design.php

Lines 6 to 10 in 5f3b86a

	namespace Magento\Framework\App\Action\Plugin;
	use Magento\Framework\Message\MessageInterface;
	class Design

Related Pull Requests

Fixed Issues (if relevant)

1. fixes Plugins in \Magento\Framework namespace #27962

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7484 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ihor-sviziev]

Hi @lbajsarowicz,
Could you review failing MHI test and update your PR?

Also I see that you moved just one plugin, could you move all plugins to corresponding modules at once?

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7484 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
Was checked that Luma theme is applied and loaded without errors
Was checked that Blank theme is applied and loaded without errors
Was checked that different themes are applied and loaded without errors on different store views
Result:

[ihor-sviziev]

@magento run all tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7484 has been created to process this Pull Request

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-7484 has been created to process this Pull Request

[lbajsarowicz]

@magento run all tests

I'd like to verify if there are no issues with current mainline.

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.